docs(input): add example of a clearable input #3730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
I'm hesitant to change the examples here until we have them building. |
|
@mmalerba can you rebase? |
|
done |
jelbourn
approved these changes
May 2, 2017
| @@ -0,0 +1,4 @@ | |||
| <md-input-container class="example-input-container"> | |||
| <input mdInput type="text" placeholder="Clearable input" [(ngModel)]="value"/> | |||
| <md-icon mdSuffix *ngIf="value" (click)="value=''">close</md-icon> | |||
There was a problem hiding this comment.
Should be an md-icon-button for a11y
There was a problem hiding this comment.
So actually... md-icon-button doesn't really work well as a suffix currently. It's too tall and it causes the placeholder and input text to be misaligned. Filed #4382 to fix this
|
icon-buttons are supported inside inputs now, updated example |
|
Needs rebase |
mmalerba
added
action: merge
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
* docs(input): add example of a clearable input * use icon button
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3725