Skip to content

fix(dialog): restoring focus too early #4329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2017
Merged

fix(dialog): restoring focus too early #4329

merged 1 commit into from
May 2, 2017

Conversation

crisbeto
Copy link
Member

Fixes the dialog restoring focus before the close animation is done.

Fixes #4287.

@crisbeto
fix(dialog): restoring focus too early
0055c76 
Fixes the dialog restoring focus before the close animation is done.

Fixes angular#4287.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 29, 2017
@crisbeto crisbeto mentioned this pull request Apr 29, 2017
Closed
jelbourn
jelbourn approved these changes May 1, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 1, 2017
@andrewseguin andrewseguin merged commit afaa2dc into angular:master May 2, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog close() from <input> event no longer works.
4 participants
@crisbeto @jelbourn @googlebot @andrewseguin