feat(core): expose ScrollDispatchModule #4501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@devversion needs rebase |
jelbourn
added
pr: needs rebase
and removed
action: merge
With angular#4251 the `ScrollDispatchModule` has been created and it is used by a lot of different components. The class is already exported inside of the file but the core package doesn't export it to the public.
devversion
force-pushed
the
feat/expose-scroll-dispatch-module
branch
from
6e31afa to
9d646f4
Compare
|
@jelbourn Done |
devversion
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #4251 the
ScrollDispatchModulehas been created and it is used by a lot of different components.The NgModule is already exported inside of the file but the core package doesn't export it to the public.
Note: Modules like that (that can be also part of the CDK at some point) should be exposed. Also it is necessary to get the secondary entry-points working.