build: faster building of tests #4509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Currently when running the tests, the library is built and afterwards the spec files are built. TypeScript then re-builds the whole library again because the spec files reference the source files (templates no longer inlined + longer building) This also fixes that the CDK isn't built with ES5 target.
devversion
force-pushed
the
build/faster-test-build
branch
from
54182a4 to
4c1320d
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running the tests, the library is built and afterwards the spec files are built.
TypeScript then re-builds the whole library again because the spec files reference the source files (templates no longer inlined + longer building)
This also fixes that the CDK isn't built with ES5 target.
Note: Building tests took for me 21 seconds and now it takes 13 seconds. Also the inlined templates should make the CI jobs run more stable.