Skip to content

build: fix umd module names #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2017
Merged

build: fix umd module names #4683

merged 1 commit into from
May 22, 2017

Conversation

devversion
Copy link
Member

  • Fixes that the UMD module names are invalid. Currently they look like ng.material.material while it should be just ng.material.

@devversion
build: fix umd module names
4c82c2e 
* Fixes that the UMD module names are invalid. Currently they look like `ng.material.material` while it should be just `ng.material`.
@devversion devversion requested a review from jelbourn May 19, 2017 16:04
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 19, 2017
jelbourn
jelbourn approved these changes May 19, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 19, 2017
@tinayuangao tinayuangao merged commit 085b459 into angular:master May 22, 2017
@devversion devversion deleted the build/fix-umd-name branch May 22, 2017 18:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @tinayuangao