Skip to content

chore(checkbox): duplicate event binding in tests #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2017
Merged

chore(checkbox): duplicate event binding in tests #4758

merged 1 commit into from
May 25, 2017

Conversation

devversion
Copy link
Member

  • Removes the duplicate event binding for the (change) event in the checkbox tests.

@devversion
chore(checkbox): duplicate event binding in tests
ac2340e 
* Removes the duplicate event binding for the `(change)` event in the checkbox tests.
@devversion devversion requested a review from tinayuangao May 23, 2017 20:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 23, 2017
tinayuangao
tinayuangao approved these changes May 23, 2017
View reviewed changes
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tinayuangao tinayuangao added action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 23, 2017
@tinayuangao tinayuangao merged commit 1789f40 into angular:master May 25, 2017
@devversion devversion deleted the chore/duplicate-event-specs-checkbox branch May 25, 2017 20:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@tinayuangao tinayuangao tinayuangao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @tinayuangao @jelbourn @googlebot