build: firebase integration for dashboard #5182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* As part of the initial dashboard setup, this installs Angular Fire and Angular Material in the dashboard. * For testing purposes the list of all payload results will be printed right now.
googlebot
added
the
cla: yes
jelbourn
approved these changes
Jun 17, 2017
tools/dashboard/package.json
Outdated
| @@ -16,10 +16,13 @@ | |||
| "@angular/core": "^4.2.2", | |||
| "@angular/forms": "^4.2.2", | |||
| "@angular/http": "^4.2.2", | |||
| "@angular/material": "^2.0.0-beta.6", | |||
There was a problem hiding this comment.
If we make this point to the build snapshot it could help give us a heads-up if something goes wrong
| } | ||
|
|
||
| /** Interface that describes the payload results from the Firebase database. */ | ||
| interface PayloadResult { |
There was a problem hiding this comment.
Move this to a file like data-definitions.ts?
There was a problem hiding this comment.
Thought about it but wanted to wait until we have more other components. I'm changing it anyway now.
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: Maybe this is rather a
choreinstead of abuild change. But should be fine though..