Skip to content

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Feb 1, 2016

Broccoli itself isn't properly checking diffs and as such takes a long
time to rebuild the app. Angular built a diffing broccoli wrapper that
does that effectively.

With this PR now the slowest tree is the TS2Dart one.

Before this change:

Hot start:

Slowest Trees Total
DiffingTSCompiler 1605ms
TSToDartTranspiler 855ms
SassCompiler 311ms
SassCompiler 293ms

Refresh:

Slowest Trees Total
DiffingTSCompiler 1169ms
TSToDartTranspiler 832ms

With the new instances

Hot start:

Slowest Trees Total
TSToDartTranspiler 692ms
DiffingTSCompiler 684ms
AutoprefixerFilter 90ms

Refresh:

Slowest Trees Total
TSToDartTranspiler 526ms
DiffingTSCompiler 61ms

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 1, 2016
@hansl
Copy link
Contributor Author

hansl commented Feb 1, 2016

@jelbourn

@hansl hansl force-pushed the broccoli-ts-diffing branch from 23e1b69 to 1761ff2 Compare February 1, 2016 17:29
@hansl hansl force-pushed the broccoli-ts-diffing branch 2 times, most recently from dffa805 to 0fa3896 Compare February 1, 2016 19:56
Broccoli itself isn't properly checking diffs and as such takes a long
time to rebuild the app. Angular built a diffing broccoli wrapper that
does that effectively.

With this PR now the slowest tree is the TS2Dart one.
@hansl hansl force-pushed the broccoli-ts-diffing branch from 0fa3896 to 710d235 Compare February 2, 2016 00:36
@hansl
Copy link
Contributor Author

hansl commented Feb 2, 2016

Apparently this doesn't work better at all, since the angular-cli import does the same. I was just skipping over a file copying step. Closing this.

@hansl hansl closed this Feb 2, 2016
@hansl hansl deleted the broccoli-ts-diffing branch February 2, 2016 00:39
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Oct 15, 2018
- changed codepen icon to a generic icon
- added tooltips
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants