docs(datepicker): datepicker overview demos #5273
Conversation
googlebot
added
the
cla: yes
| templateUrl: 'datepicker-api-example.html', | ||
| styleUrls: ['datepicker-api-example.css'], | ||
| }) | ||
| export class DatepickerAPIExample { |
There was a problem hiding this comment.
DatepickerApiExample (acronyms are camelCased too)
# Conflicts: # src/material-examples/example-module.ts
| <input mdInput [mdDatepicker]="picker" placeholder="Choose a date"> | ||
| </md-input-container> | ||
| <md-datepicker #picker></md-datepicker> | ||
| <button md-raised-button (click)="picker.open()">Open</button> No newline at end of file |
There was a problem hiding this comment.
a number of files are missing newline at end, you should configure your editor to insert it
| styleUrls: ['datepicker-filter-example.css'], | ||
| }) | ||
| export class DatepickerFilterExample { | ||
| myFilter = (d: Date) => d.getFullYear() > 2017; |
There was a problem hiding this comment.
this could just be accomplished with min, i would use an example that illustrates why you would actually use filter (e.g. disabled odd dates)
There was a problem hiding this comment.
Ya, I have a example for min/max, this is to demonstrate filters.
There was a problem hiding this comment.
Miles means that the example for filtering should show something else (e.g., filter out weekends).
|
I addressed the items requested, ready for review. |
| export class DatepickerFilterExample { | ||
| myFilter = (d: Date): boolean => { | ||
| const day = d.getDay(); | ||
| return day !== 0 && day !== 6; |
There was a problem hiding this comment.
Would be good to add a comment like
// Prevent Saturday and Sunday from being selected.
|
Done :) |
* docs(datepicker): datepicker overview demos * chore(*): rename `DatePickerAPIExample` to `DatepickerApiExample` * chore(*): files end w/ new lines * chore(demo): update date filter demo to exclude weekends * docs(datepicker): add comments to filter * chore(lint): fix lint errors
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
4 participants
Add datepicker demos for: