fix(autocomplete): allow number zero as value #5364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently the autocomplete does not properly display the selected options with the number zero as value. Fixes angular#5363.
googlebot
added
the
cla: yes
kara
approved these changes
Jun 26, 2017
| @@ -358,7 +358,9 @@ export class MdAutocompleteTrigger implements ControlValueAccessor, OnDestroy { | |||
|
|
|||
| private _setTriggerValue(value: any): void { | |||
| const toDisplay = this.autocomplete.displayWith ? this.autocomplete.displayWith(value) : value; | |||
| this._element.nativeElement.value = toDisplay || ''; | |||
| // Simply falling back to an empty string if the display value is falsy does not work properly. | |||
| // The display value can also be the number zero and shouldn't fallback to an empty string. | |||
devversion
force-pushed
the
fix/autocomplete-number-zero
branch
from
c5ec6eb to
a98a8c1
Compare
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
* fix(autocomplete): allow number zero as value * Currently the autocomplete does not properly display the selected options with the number zero as value. Fixes angular#5363. * Fix typo
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5363.