Skip to content

Conversation

andrewseguin
Copy link
Contributor

No description provided.

@andrewseguin andrewseguin requested a review from jelbourn June 30, 2017 20:37
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 30, 2017
@CaerusKaru CaerusKaru mentioned this pull request Jul 1, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will probably need a rebase too

* Styles to make the demo's cdk-table match the material design spec
* https://material.io/guidelines/components/data-tables.html
*/
.cdk-table {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example styles should all be prefixed with example- so people don't think that the styles from the demo are supposed to be there in the component by itself

@@ -0,0 +1,89 @@
import {Component} from '@angular/core';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file starts with ckd

@andrewseguin
Copy link
Contributor Author

Rebased, did changes

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 5, 2017
@mmalerba mmalerba merged commit 6499ccb into angular:master Jul 5, 2017
amcdnl pushed a commit to amcdnl/material2 that referenced this pull request Jul 8, 2017
* docs(table): initial table docs

* add filtering msg

* add overview

* fix height

* split cdk table into guide

* revisions

* add to examples

* fix heading

* example changes

* lint

* example style prefix, rename file

* newline
@andrewseguin andrewseguin deleted the table-docs branch November 28, 2017 20:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants