refactor: fix flaky focus origin tests #5454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
added
pr: merge safe
and removed
in progress
Fixes failures in the `FocusOriginMonitor` tests on IE, if the browser is in focus. The issue comes from the fact that IE will trigger the `focus` handlers asynchronously, whereas other browsers are synchronous. Here's an example log: ``` IE 11.0.0 (Windows 10 0.0.0) LOG: 'dispatching events' IE 11.0.0 (Windows 10 0.0.0) LOG: 'making assertions' IE 11.0.0 (Windows 10 0.0.0) LOG: 'focus event fired' ----------------------------------------------------------- Chrome 59.0.3071 (Windows 10 0.0.0) LOG: 'dispatching events' Chrome 59.0.3071 (Windows 10 0.0.0) LOG: 'focus event fired' Chrome 59.0.3071 (Windows 10 0.0.0) LOG: 'making assertions' ``` The issue only happens when the browser is focused, because the `patchElementFocus` function will override the native `focus` method with a synchronous one only if the browser is **not** focused. These changes make it so the native event is always overwritten, in order to make the tests a little more predictable. Also switches all the tests from `async` to `fakeAsync` to avoid using `setTimeout` in tests.
crisbeto
force-pushed
the
focus-origin-ie-failures
branch
from
aa792b6 to
afdb9b7
Compare
crisbeto
changed the title
jelbourn
added
pr: lgtm
action: merge
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
Fixes failures in the `FocusOriginMonitor` tests on IE, if the browser is in focus. The issue comes from the fact that IE will trigger the `focus` handlers asynchronously, whereas other browsers are synchronous. Here's an example log: ``` IE 11.0.0 (Windows 10 0.0.0) LOG: 'dispatching events' IE 11.0.0 (Windows 10 0.0.0) LOG: 'making assertions' IE 11.0.0 (Windows 10 0.0.0) LOG: 'focus event fired' ----------------------------------------------------------- Chrome 59.0.3071 (Windows 10 0.0.0) LOG: 'dispatching events' Chrome 59.0.3071 (Windows 10 0.0.0) LOG: 'focus event fired' Chrome 59.0.3071 (Windows 10 0.0.0) LOG: 'making assertions' ``` The issue only happens when the browser is focused, because the `patchElementFocus` function will override the native `focus` method with a synchronous one only if the browser is **not** focused. These changes make it so the native event is always overwritten, in order to make the tests a little more predictable. Also switches all the tests from `async` to `fakeAsync` to avoid using `setTimeout` in tests.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failures in the
FocusOriginMonitortests on IE, if the browser is in focus. The issue comes from the fact that IE will trigger thefocushandlers asynchronously, whereas other browsers are synchronous. Here's an example log:The issue happens when the browser is focused, because the
patchElementFocusfunction will override the nativefocusmethod with a synchronous one only if the browser is not focused. These changes make it so the native event is always overwritten, in order to make the tests a little more predictable. Also switches all the tests fromasynctofakeAsyncto avoid usingsetTimeoutin tests.