chore: remove invalid rx type dependency #5462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* At some point the `@types/rx` package has been added as a dependency on the project. The `@types/rx` are not for the RxJS implementation that Angular uses. Also RxJS provides typings on it's own since it's build using TypeScript.
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
amcdnl
pushed a commit
to amcdnl/material2
that referenced
this pull request
Jul 8, 2017
* At some point the `@types/rx` package has been added as a dependency on the project. The `@types/rx` are not for the RxJS implementation that Angular uses. Also RxJS provides typings on it's own since it's build using TypeScript.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@types/rxpackage has been added as a dependency on the project. The@types/rxare not for the RxJS implementation that Angular uses. Also RxJS provides typings on it's own since it's build using TypeScript.Note: The annoying package-lock changes that are always appearing should go away in the future with: npm/npm#16866 (comment) (Not a big deal for now)