Skip to content

Conversation

kara
Copy link
Contributor

@kara kara commented May 29, 2016

r: @jelbourn

This PR adds header and footer support to grid-lists.

Example use:

<md-grid-list cols="3">
   <md-grid-tile *ngFor="let image of images">
      <md-grid-tile-footer>
           <h3 md-line> Title </h3>
           <span md-line> Description </span>
           <md-icon>star_border</md-icon>
      </md-grid-tile-footer>
    </md-grid-tile>
</md-grid-list>

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 29, 2016

/* font styles for text in tile headers and footers */
$md-grid-font-size: 16px;
$md-grid-secondary-font: 12px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the variables be gridlist instead of grid? Many people refer to 'data-table" as "grid", so I want to avoid confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch. I can change.

@kara
Copy link
Contributor Author

kara commented May 31, 2016

@jelbourn Comments should be addressed

})
export class MdGridTileText implements AfterContentInit {
/* Helper that watches the number of lines in a text area and sets
* a class on the host element that matches the line count. */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format should be

/**
 * Helper that watches the number of lines in a text area and sets
 * a class on the host element that matches the line count.
 */

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(here and for other block-style comments)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are hard

@jelbourn
Copy link
Member

jelbourn commented Jun 1, 2016

LGTM aside from comment format

@kara
Copy link
Contributor Author

kara commented Jun 1, 2016

Fixed comment formatting. Merging!

@kara kara merged commit 43806f6 into angular:master Jun 1, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants