-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(grid-list): add header and footer support #571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
/* font styles for text in tile headers and footers */ | ||
$md-grid-font-size: 16px; | ||
$md-grid-secondary-font: 12px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the variables be gridlist
instead of grid
? Many people refer to 'data-table" as "grid", so I want to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good catch. I can change.
@jelbourn Comments should be addressed |
}) | ||
export class MdGridTileText implements AfterContentInit { | ||
/* Helper that watches the number of lines in a text area and sets | ||
* a class on the host element that matches the line count. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format should be
/**
* Helper that watches the number of lines in a text area and sets
* a class on the host element that matches the line count.
*/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(here and for other block-style comments)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are hard
LGTM aside from comment format |
Fixed comment formatting. Merging! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
r: @jelbourn
This PR adds header and footer support to grid-lists.
Example use: