feat(md-progress-circle) #60
Conversation
googlebot
added
the
cla: yes
| @import "default-theme"; | ||
|
|
||
|
|
||
| $circle-ease-in-out : cubic-bezier(0.35, 0, 0.25, 1) !default; |
There was a problem hiding this comment.
This should be in a core/ scss var with the other animations.
There was a problem hiding this comment.
All of the vars should be prefixed with md- so that people can combine them with their own scss builds eventually.
josephperrott
force-pushed
the
md-progress-circle
branch
from
376cb3a to
e514f74
Compare
|
You can change this after other changes to avoid diff noise, but the files should be dash-case. |
| } | ||
|
|
||
| &.md-accent circle { | ||
| stroke: md-color($md-accent, 100); |
There was a problem hiding this comment.
Why are these set to the 100 hue?
|
Done with my first round of comments. |
josephperrott
force-pushed
the
md-progress-circle
branch
3 times, most recently
from
927ab3f to
b5656a1
Compare
|
|
||
| /* Animation Durations */ | ||
| $md-progress-circle-duration : 5.25s !default; | ||
| $md-progress-circle-value-change-duration : $md-progress-circle-duration * (1 / 4) !default; |
|
Added just a last few minor nits. |
josephperrott
force-pushed
the
md-progress-circle
branch
from
b5656a1 to
070c63a
Compare
|
LGTM There will certainly be some DartAnalyzer problems, but those can be addressed in a follow-up PR. @josephperrott I can merge this if you don't have any further changes you wanted to make. |
josephperrott
force-pushed
the
md-progress-circle
branch
from
070c63a to
dcff738
Compare
|
@jelbourn I have made all of the changes and pushed. Ready to go. |
* Fix asset urls for examples that load images/icons * Missing semi-colon * asset
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Create the MdProgressCircle component as described here:
https://docs.google.com/document/d/1tFr8nFOAqCMO71EtOsNCYvGnmGQhcNWxr5dAzWWa93o/