fix(autocomplete): emit closing action for escape keydown event #6250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
willshowell
force-pushed
the
autocomplete-escape-stream
branch
from
549b86c to
133b03f
Compare
willshowell
force-pushed
the
autocomplete-escape-stream
branch
3 times, most recently
from
8d5b0b6 to
6d8da62
Compare
willshowell
force-pushed
the
autocomplete-escape-stream
branch
from
6d8da62 to
47088f6
Compare
|
@kara @crisbeto would one of you mind reviewing this? It's really simple and a big help for #3334 (comment). |
crisbeto
reviewed
Sep 13, 2017
| if (event.keyCode === ESCAPE && this.panelOpen) { | ||
| this._resetActiveItem(); | ||
| this.closePanel(); | ||
| this._escapeEventStream.next(event); |
There was a problem hiding this comment.
Since it only fires for escape presses, I don't think it's necessary to pass along the event.
| private _closingActionsSubscription: Subscription; | ||
|
|
||
| /** Stream of escape keyboard events. */ | ||
| private _escapeEventStream = new Subject<KeyboardEvent>(); |
There was a problem hiding this comment.
Can you also complete this in ngOnDestroy?
crisbeto
added
pr: lgtm
action: merge
willshowell
force-pushed
the
autocomplete-escape-stream
branch
2 times, most recently
from
e134ecc to
c6cd992
Compare
willshowell
force-pushed
the
autocomplete-escape-stream
branch
from
c6cd992 to
b61af4f
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6209
This also adds tests for the existing
panelClosingActions