Skip to content

refactor(slider): use color mixin with coercing #6371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

devversion
Copy link
Member

  • The color attribute for the slider now uses the color mixin as every other component that is themable. This means that the color binding is now coerced for the sliders.

Closes #6368

@devversion devversion requested a review from mmalerba as a code owner August 9, 2017 12:59
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 9, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 9, 2017
@andrewseguin
Copy link
Contributor

Needs rebase

@kara kara assigned devversion and unassigned mmalerba Aug 21, 2017
@kara kara removed the action: merge The PR is ready for merge by the caretaker label Aug 21, 2017
@kara
Copy link
Contributor

kara commented Aug 21, 2017

@devversion Can you rebase this when you get a chance?

* The color attribute for the slider now uses the `color` mixin as every other component that is themable. This means that the color binding is now coerced for the sliders.

Closes angular#6368
@devversion devversion force-pushed the refactor/slider-color-mixin branch from 5513ade to 54bfad6 Compare August 23, 2017 15:07
@devversion
Copy link
Member Author

@kara Done.

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Aug 23, 2017
@kara kara merged commit c4a5d7a into angular:master Aug 23, 2017
@devversion devversion deleted the refactor/slider-color-mixin branch November 11, 2017 10:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MD-Slider No Color
5 participants