Skip to content

Conversation

willshowell
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 17, 2017
@jelbourn
Copy link
Member

Adding (focus) to the md-chip element already works since the chip element is the thing that receives focus; why would this need to be an @Output?

@willshowell
Copy link
Contributor Author

@jelbourn tbh I didn't investigate, I just noticed it stood out in the api docs. Happy to repurpose this PR to removing it entirely.

Name Description
@Input()selected Whether the chip is selected.
onFocus Emitted when the chip is focused.
@Output()select Emitted when the chip is selected.
@Output()deselect Emitted when the chip is deselected.
@Output()destroy Emitted when the chip is destroyed.

@jelbourn
Copy link
Member

Ah, I see. It should just be internal (_onFocus) since it's used by the chip-list but not meant to be a public API

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn changed the title fix(chip): make onFocus an Output fix(chip): mark onFocus as internal Aug 17, 2017
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 17, 2017
@kara kara merged commit 449ed19 into angular:master Aug 22, 2017
@willshowell willshowell deleted the patch-3 branch August 22, 2017 21:03
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants