Skip to content

refactor: turn off view encapsulation for all components #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2017
Merged

refactor: turn off view encapsulation for all components #6563

merged 1 commit into from
Aug 23, 2017

Conversation

crisbeto
Copy link
Member

  • Adds a tslint rule enforce that we don't use view encapsulation on any component.
  • Refactors a few components not to use view encapsulation.

Fixes #6037.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 20, 2017
@crisbeto crisbeto force-pushed the 6037/view-encapsulation branch from 88e7e90 to 2b45005 Compare August 20, 2017 15:03
@crisbeto crisbeto requested a review from devversion as a code owner August 20, 2017 15:03
jelbourn
jelbourn approved these changes Aug 21, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 21, 2017
@kara kara removed their request for review August 21, 2017 17:31
@crisbeto crisbeto force-pushed the 6037/view-encapsulation branch from 2b45005 to ac46181 Compare August 22, 2017 05:20
@kara kara added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Aug 22, 2017
@kara kara assigned crisbeto and unassigned jelbourn Aug 22, 2017
@kara
Copy link
Contributor

kara commented Aug 22, 2017

@crisbeto Rebase?

@crisbeto
refactor: turn off view encapsulation for all components
2ded188 
* Adds a tslint rule enforce that we don't use view encapsulation on any component.
* Refactors a few components not to use view encapsulation.

Fixes angular#6037.
@crisbeto crisbeto force-pushed the 6037/view-encapsulation branch from ac46181 to 2ded188 Compare August 22, 2017 21:23
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Aug 22, 2017
@crisbeto
Copy link
Member Author

Rebased.

@kara kara merged commit 2fc6a4c into angular:master Aug 23, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@josephperrott josephperrott Awaiting requested review from josephperrott

@mmalerba mmalerba Awaiting requested review from mmalerba

@devversion devversion Awaiting requested review from devversion

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: enforce view encapsulation across components
4 participants
@crisbeto @kara @jelbourn @googlebot