Skip to content

chore(e2e): fix consistent timeouts #6574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2017
Merged

chore(e2e): fix consistent timeouts #6574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 39 additions & 7 deletions tools/gulp/tasks/screenshots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,46 @@ task('screenshots', () => {
const firebaseApp = connectFirebaseScreenshots();
const database = firebaseApp.database();

// If this task hasn't completed in 8 minutes, close the firebase connection.
const timeoutId = setTimeout(() => {
console.error('Screenshot tests did not finish in 8 minutes, closing Firebase connection.');
return firebaseApp.delete();
}, 60 * 1000 * 8);

let lastActionTime = Date.now();
return uploadTravisJobInfo(database, prNumber)
.then(() => downloadGoldScreenshotFiles(database))
.then(() => compareScreenshotFiles(database, prNumber))
.then(passedAll => setPullRequestResult(database, prNumber, passedAll))
.then(() => uploadScreenshotsData(database, 'diff', prNumber))
.then(() => uploadScreenshotsData(database, 'test', prNumber))
.catch((err: any) => console.error(err))
.then(() => firebaseApp.delete());
.then(() => {
console.log(` Downloading screenshot golds from Firebase...`);
lastActionTime = Date.now();
return downloadGoldScreenshotFiles(database);
})
.then(() => {
console.log(` Downloading golds done (took ${Date.now() - lastActionTime}ms)`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want these to be formatted better, you can import {log} from 'gulp-util'.

console.log(` Comparing screenshots golds to test result screenshots...`);
lastActionTime = Date.now();
return compareScreenshotFiles(database, prNumber);
})
.then(passedAll => {
console.log(` Comparison done (took ${Date.now() - lastActionTime}ms)`);
console.log(` Uploading screenshot diff results to Firebase and GitHub...`);
lastActionTime = Date.now();
return Promise.all([
setPullRequestResult(database, prNumber, passedAll),
uploadScreenshotsData(database, 'diff', prNumber),
uploadScreenshotsData(database, 'test', prNumber),
]);
})
.then(() => {
console.log(` Uploading results done (took ${Date.now() - lastActionTime}ms)`);
firebaseApp.delete();
clearTimeout(timeoutId);
})
.catch((err: any) => {
console.error(` Screenshot tests encountered an error!`);
console.error(err);
firebaseApp.delete();
clearTimeout(timeoutId);
});
}
});

Expand Down