Skip to content

fix(autocomplete): remove invalid aria markup #7107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(autocomplete): remove invalid aria markup #7107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/lib/autocomplete/autocomplete-trigger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ export function getMdAutocompleteMissingPanelError(): Error {
'role': 'combobox',
'autocomplete': 'off',
'aria-autocomplete': 'list',
'aria-multiline': 'false',
'[attr.aria-activedescendant]': 'activeOption?.id',
'[attr.aria-expanded]': 'panelOpen.toString()',
'[attr.aria-owns]': 'autocomplete?.id',
Expand Down
5 changes: 0 additions & 5 deletions src/lib/autocomplete/autocomplete.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,11 +1104,6 @@ describe('MdAutocomplete', () => {
.toEqual('list', 'Expected aria-autocomplete attribute to equal list.');
});

it('should set aria-multiline to false', () => {
expect(input.getAttribute('aria-multiline'))
.toEqual('false', 'Expected aria-multiline attribute to equal false.');
});

it('should set aria-activedescendant based on the active option', async(() => {
fixture.componentInstance.trigger.openPanel();
fixture.detectChanges();
Expand Down