Skip to content

fix(sort): throw error on invalid direction #7378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(sort): throw error on invalid direction #7378

merged 1 commit into from
Sep 29, 2017

Conversation

andrewseguin
Copy link
Contributor

Fixes #7291

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Sep 27, 2017
@andrewseguin andrewseguin mentioned this pull request Sep 27, 2017
Closed
@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Sep 27, 2017
@angular angular deleted a comment from googlebot Sep 27, 2017
@angular angular deleted a comment from andrewseguin Sep 27, 2017
@angular angular deleted a comment from googlebot Sep 27, 2017
jelbourn
jelbourn approved these changes Sep 27, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 27, 2017
@andrewseguin andrewseguin merged commit cc6f39e into angular:master Sep 29, 2017
@andrewseguin andrewseguin deleted the sort-init-funny branch November 28, 2017 20:40
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Table] Sort arrows are not rendered properly in tabs
3 participants
@andrewseguin @jelbourn @googlebot