Skip to content

chore: update angular to 4.4.4 and switch select to use nbsp again #7431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2017
Merged

chore: update angular to 4.4.4 and switch select to use nbsp again #7431

merged 1 commit into from
Oct 3, 2017

Conversation

mmalerba
Copy link
Contributor

also moved the allowSyntheticDefaultImports to the material-moment-adapter specific tsconfig, since thats a thing now

@mmalerba mmalerba requested a review from crisbeto September 29, 2017 23:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 29, 2017
jelbourn
jelbourn approved these changes Oct 2, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 2, 2017
@mmalerba mmalerba added the P2 The issue is important to a large percentage of users, with a workaround label Oct 2, 2017
@kara kara merged commit 38bec5c into angular:master Oct 3, 2017
@mmalerba mmalerba mentioned this pull request Oct 13, 2017
Open
@mmalerba mmalerba deleted the select-nbsp2 branch July 31, 2018 21:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@devversion devversion Awaiting requested review from devversion

@kara kara Awaiting requested review from kara

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmalerba @jelbourn @kara @crisbeto @googlebot