Skip to content

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Oct 4, 2017

This PR resolves issues with overflow due to out-dated example code. Ref: #7509

@amcdnl amcdnl self-assigned this Oct 4, 2017
@amcdnl amcdnl requested a review from mmalerba October 4, 2017 14:10
@amcdnl amcdnl requested a review from jelbourn as a code owner October 4, 2017 14:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 4, 2017
(matChipInputTokenEnd)="add($event)" />
</mat-form-field>
</mat-chip-list>
</mat-form-field>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: \n

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

</mat-chip>
</mat-chip-list>
<input matInput placeholder="New fruit..."
<input matInput placeholder="New fruit..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove matInput

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 4, 2017
@kara kara merged commit edd7924 into angular:master Oct 5, 2017
@amcdnl amcdnl deleted the chip-input-example branch October 5, 2017 18:02
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants