Skip to content

chore(keycodes): add comma to keycodes and update usages #7852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

amcdnl
Copy link
Contributor

@amcdnl amcdnl commented Oct 17, 2017

This PR adds COMMA to the keycodes and updates all the usages where it was manually defined.

@amcdnl amcdnl self-assigned this Oct 17, 2017
@amcdnl amcdnl requested a review from jelbourn October 17, 2017 14:31
@amcdnl amcdnl requested a review from tinayuangao as a code owner October 17, 2017 14:31
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 17, 2017
@amcdnl
Copy link
Contributor Author

amcdnl commented Oct 17, 2017

Note: It would be cool to change this to a string enum and add the rest of the keycodes.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Why a string enum? Either way, using an enum would be bad for payload size; as separate constants, unused symbols can be tree-shaken away, but a a single enum cannot be broken up.

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 18, 2017
@amcdnl
Copy link
Contributor Author

amcdnl commented Oct 20, 2017

@jelbourn - Gotcha. Thanks for the feedback.

Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit dff9727 into angular:master Nov 2, 2017
@amcdnl amcdnl deleted the comma-keycode branch November 2, 2017 18:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants