Skip to content

cleanup(datepicker): undo breaking change to NativeDateAdapter #8281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2017
Merged

cleanup(datepicker): undo breaking change to NativeDateAdapter #8281

merged 1 commit into from
Nov 7, 2017

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Nov 7, 2017

No description provided.

@mmalerba mmalerba added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: needs review labels Nov 7, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 7, 2017
josephperrott
josephperrott approved these changes Nov 7, 2017
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 7, 2017
@josephperrott josephperrott merged commit 8b3c8a5 into angular:master Nov 7, 2017
@mmalerba mmalerba deleted the dp-brk branch July 31, 2018 21:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmalerba @josephperrott @googlebot