fix(list): multi-line list item spacing #8339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
commented
Nov 9, 2017
| @@ -23,12 +24,13 @@ $mat-dense-base-height: 40px; | |||
| $mat-dense-avatar-height: 48px; | |||
| $mat-dense-two-line-height: 60px; | |||
| $mat-dense-three-line-height: 76px; | |||
| $mat-dense-multi-line-padding: 16px; | |||
There was a problem hiding this comment.
Note that the dense padding here is the same as the regular one, however the spec doesn't seem to mention exactly how to handle more than three lines. I based this number on the spacing between the text and the element top for three-line items.
jelbourn
added
merge: caretaker note
|
Caretaker note: this needs extra caution, perhaps reaching out to teams |
* Fixes the spacing on multi-line list items being off. * Fixes a couple of declarations with the exact same styles being duplicated, adding some bloat to the final output. Fixes angular#8333.
crisbeto
force-pushed
the
8333/multi-line-list-item
branch
from
2c1271e to
348ebb3
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8333.