fix(autocomplete): return consistent output from panelClosingActions #8533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
crisbeto
added
target: minor
crisbeto
force-pushed
the
7553/autocomplete-consistent-return
branch
from
063c12c to
6e63246
Compare
andrewseguin
added
the
presubmit failures
crisbeto
force-pushed
the
7553/autocomplete-consistent-return
branch
from
6e63246 to
bffa4b3
Compare
Currently the `panelClosingActions` stream is typed to return a `MatOptionSelectionChange` event, however the real return data is `MatOptionSelectionChange|void|MouseEvent`, which makes it hard to use. These changes switch to emitting a `null` if nothing was selected or `MatOptionSelectionChange` if the user selected something. Fixes angular#7553.
crisbeto
force-pushed
the
7553/autocomplete-consistent-return
branch
from
bffa4b3 to
7d8bd7e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
panelClosingActionsstream is typed to return aMatOptionSelectionChangeevent, however the real return data isMatOptionSelectionChange|void|MouseEvent, which makes it hard to use. These changes switch to emitting anullif nothing was selected orMatOptionSelectionChangeif the user selected something.Fixes #7553.