fix(menu): Set menu-item icon color only when not set on mat-icon #8614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the theme icon color only if the `color` input property was not set on the `mat-icon` component. Fixes #8594
googlebot
added
the
cla: yes
Add unit tests for setting the mat-icon[color] attribute on a menu item
Related to #8594
glenstaes
changed the title
crisbeto
reviewed
Nov 29, 2017
src/lib/menu/menu.spec.ts
Outdated
| expect(fixture.componentInstance.items.first.getLabel()).toBe('Item'); | ||
| }); | ||
|
|
||
| it('should have an icon with the default theme color if mat-icon has no color attribute set', |
There was a problem hiding this comment.
You can get rid of these tests since they're basically testing the CSS engine.
src/lib/menu/menu.spec.ts
Outdated
| dir = 'ltr'; | ||
| TestBed.configureTestingModule({ | ||
| imports: [MatMenuModule, NoopAnimationsModule], | ||
| imports: [MatIconModule, MatMenuModule, NoopAnimationsModule], |
There was a problem hiding this comment.
In general we try to avoid having dependencies between components like this. It shouldn't be an issue after the previous comment about removing the tests is addressed.
|
@crisbeto Comments have been addressed |
crisbeto
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the theme icon color only if the
colorinput property was not set on themat-iconcomponent.Fixes #8594