Skip to content

Conversation

devversion
Copy link
Member

@devversion devversion commented Nov 27, 2017

  • Sometimes the focus origin is not valid because Firefox seems to focus a tick after the keyboard/interaction event fired. To ensure the focus origin is always correct, the focus origin will be added to the beginning of the event loop in the next tick.

Fixes #6984

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 27, 2017
@devversion devversion force-pushed the fix/focus-origin-firefox-57 branch from 9c6f8df to 12b19d1 Compare November 27, 2017 19:32
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 27, 2017
@mmalerba mmalerba added this to the 5.2 milestone Nov 27, 2017
@devversion devversion force-pushed the fix/focus-origin-firefox-57 branch from 12b19d1 to 27b1bad Compare December 31, 2017 11:14
@devversion devversion added the target: patch This PR is targeted for the next patch release label Jan 20, 2018
@mmalerba mmalerba added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Jan 25, 2018
@mmalerba
Copy link
Contributor

needs rebase

@devversion devversion force-pushed the fix/focus-origin-firefox-57 branch from 27b1bad to 88f5ea4 Compare January 27, 2018 15:05
@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jan 30, 2018
@mmalerba
Copy link
Contributor

mmalerba commented Apr 17, 2018

@devversion please rebase, re-apply merge ready when done

@mmalerba mmalerba removed the action: merge The PR is ready for merge by the caretaker label Apr 18, 2018
@devversion devversion force-pushed the fix/focus-origin-firefox-57 branch from 88f5ea4 to b75c7e5 Compare June 28, 2018 15:28
@devversion
Copy link
Member Author

@mmalerba Rebased. I didn't apply merge ready because I'm not sure whether we still want to go that way.

* Sometimes the focus origin is not valid because Firefox seems to focus a tick after the keyboard/interaction event fired a tick before. To ensure the focus origin is always correct, the focus origin will be added to the next tick event loop

Fixes angular#6984
@devversion devversion force-pushed the fix/focus-origin-firefox-57 branch from b75c7e5 to d43c144 Compare July 2, 2018 16:54
@mmalerba
Copy link
Contributor

mmalerba commented Jul 3, 2018

I think we should try, it may wind up causing too many failures in google3 to be feasible. I'll mark it merge ready so the caretaker can at least try though

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jul 3, 2018
@ngbot
Copy link

ngbot bot commented Jul 3, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba
Copy link
Contributor

mmalerba commented Jul 3, 2018

@devversion it looks like we did presubmit this a while back and it seemed fine, it has a failing test on travis though

@devversion
Copy link
Member Author

@mmalerba Should be fixed now.

@devversion devversion removed this from the 5.2 milestone Jul 9, 2018
@jelbourn jelbourn merged commit a1aa9e7 into angular:master Jul 10, 2018
victoriaaa234 pushed a commit that referenced this pull request Jul 25, 2018
Sometimes the focus origin is not valid because Firefox seems to focus a tick after the keyboard/interaction event fired a tick before. To ensure the focus origin is always correct, the focus origin will be added to the next tick event loop

Fixes #6984
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox: focus effect sometimes not showing up in Firefox
4 participants