Skip to content

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Dec 12, 2017

Fixes #8942

@jelbourn jelbourn added docs This issue is related to documentation pr: merge safe labels Dec 12, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 12, 2017
README.md Outdated
| virtual-repeat | Not started, planned Q4 2017 | - | [#823][0823] |
| sticky-header | In-progress, planned Q2 2018 | - | [#474][0474] |
| virtual-repeat | Prototyping, planned Q1 2018 | - | [#823][0823] |
| badge | In-progress, planned Q4 2017 | - | [#823][0823] |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you forgot to edit the linked issue, #3058 is the right one.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 21, 2017
@jelbourn jelbourn merged commit 3f31171 into angular:master Jan 2, 2018
| virtual-repeat | Not started, planned Q4 2017 | - | [#823][0823] |
| sticky-header | In-progress, planned Q2 2018 | - | [#474][0474] |
| virtual-repeat | Prototyping, planned Q1 2018 | - | [#823][0823] |
| badge | In-progress, planned Q4 2017 | - | [#3085][3058] |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jelbourn typo: link text is 3085, should be 3058

@fxck
Copy link
Contributor

fxck commented Jan 3, 2018

Is badge planned to be done in the past?

@jelbourn jelbourn deleted the readme-stable branch April 2, 2018 22:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Readme needs to be updated
5 participants