Skip to content

fix(tooltip): match mobile dimensions from spec #9181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2018
Merged

fix(tooltip): match mobile dimensions from spec #9181

merged 1 commit into from
Jan 31, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 1, 2018

Updates the various tooltip dimensions to match the spec on mobile.

Fixes #9039.

@crisbeto crisbeto requested a review from andrewseguin as a code owner January 1, 2018 14:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 1, 2018
@crisbeto crisbeto force-pushed the 9039/tooltip-mobile-dimensions branch 2 times, most recently from b742469 to f01f668 Compare January 2, 2018 08:18
@donroyco
Copy link
Contributor

donroyco commented Jan 2, 2018

@crisbeto Thanks for picking it up.

andrewseguin
andrewseguin approved these changes Jan 25, 2018
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 25, 2018
@jelbourn
Copy link
Member

@crisbeto needs rebase

@crisbeto crisbeto force-pushed the 9039/tooltip-mobile-dimensions branch from f01f668 to b1427a8 Compare January 26, 2018 19:11
@crisbeto
Copy link
Member Author

Rebased.

@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed pr: needs rebase labels Jan 26, 2018
@tinayuangao tinayuangao merged commit 63a5588 into angular:master Jan 31, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tooltip: mobile font size is too small
6 participants
@crisbeto @donroyco @jelbourn @andrewseguin @googlebot @tinayuangao