Skip to content

chore: add missing @deletion-target tags #9734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2018
Merged

chore: add missing @deletion-target tags #9734

merged 2 commits into from
Feb 3, 2018

Conversation

devversion
Copy link
Member

@devversion devversion commented Feb 1, 2018 •
edited
Loading

  • Adds the missing @deletion-target tags

@devversion
chore: add missing @deletion-target tags
7b6d887 
* Adds the missing @deletion-target tags
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 1, 2018
jelbourn
jelbourn approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

jelbourn commented Feb 1, 2018

Were all of these marked as deprecated when 5.0.0 came out?

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 1, 2018
@tinayuangao tinayuangao merged commit 4523ecd into angular:master Feb 3, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto Awaiting requested review from crisbeto

@josephperrott josephperrott Awaiting requested review from josephperrott

@tinayuangao tinayuangao Awaiting requested review from tinayuangao

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @tinayuangao