docs: simplify filtering of alias exports #9893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Feb 11, 2018
devversion
commented
- Simplifies the processor that filters alias exports. This is now possible with angular/dgeni-packages@f703414
* Simplifies the processor that filters alias exports. This is now possible with angular/dgeni-packages@f703414
googlebot
added
the
cla: yes
devversion
commented
Feb 11, 2018
| // shouldn't be filtered. This check is necessary, because technically as per TypeScript, | ||
| // explicit and individual re-exports are being considered as aliases. | ||
| // For example: export {Test} from './my-file`; | ||
| return !(doc.aliasSymbol && doc.aliasSymbol.name !== doc.symbol.name); |
There was a problem hiding this comment.
This could have been made without the parentheses, but I wanted to make clear what is considered a aliased export.
jelbourn
added
pr: lgtm
action: merge
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2018
Simplifies the processor that filters alias exports. This is now possible with angular/dgeni-packages@f703414
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.