This repository was archived by the owner on Apr 4, 2025. It is now read-only.
feat(@angular-devkit/core): add support for color and no-color #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
suggested changes
Nov 21, 2017
| color256: level > 1, | ||
| color16m: level > 2, | ||
|
|
||
| rows: isTerminalStream ? _getRows() : null, |
There was a problem hiding this comment.
I think you can use stream.isTTY instead of passing in isTerminalStream: https://nodejs.org/api/tty.html.
We had a PR for doing that in the CLI recently angular/angular-cli#8501
There was a problem hiding this comment.
I've set the default to it, but technically this could be used outside of Node. I've let that other PR in, that's actually nice to have.
hansl
force-pushed
the
terminal-colors
branch
from
57ed2c7 to
39b16c2
Compare
And namespace the terminal.
hansl
force-pushed
the
terminal-colors
branch
from
39b16c2 to
2e14a37
Compare
filipesilva
approved these changes
Nov 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And namespace the terminal.