This repository was archived by the owner on Apr 4, 2025. It is now read-only.
fix(@schematics/angular): ignore system files in service worker #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes angular/mobile-toolkit#180 When copying the assets, the CLI includes system files (e.g. .DS_Store and Thumbs.db). As a consequence, they are included in the service worker manifest as files to cache. But such file may (and should) not be deployed to the server, then a file will be missing, then the service worker installation will fail and so all the offline feature won't work. This PR ensure the service worker will ignore these system files.
|
A better solution may be for the CLI to not copy those files when building. |
|
Closing as replaced by a better solution in angular/angular-cli#8549 |
hansl
pushed a commit
to angular/angular-cli
that referenced
this pull request
Nov 20, 2017
Replaces angular/devkit#263 When copying the assets during build, the CLI must not include system files (e.g. `.DS_Store` and `Thumbs.db`). It is very important for service worker to work : if presents, these files will be included in the service worker manifest as files to cache. But such files may (and should) not be deployed to the server. Then on the client, files will be missing, then the service worker installation will fail and so all the offline feature won't work.
hansl
pushed a commit
to angular/angular-cli
that referenced
this pull request
Nov 23, 2017
Replaces angular/devkit#263 When copying the assets during build, the CLI must not include system files (e.g. `.DS_Store` and `Thumbs.db`). It is very important for service worker to work : if presents, these files will be included in the service worker manifest as files to cache. But such files may (and should) not be deployed to the server. Then on the client, files will be missing, then the service worker installation will fail and so all the offline feature won't work.
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
Replaces angular/devkit#263 When copying the assets during build, the CLI must not include system files (e.g. `.DS_Store` and `Thumbs.db`). It is very important for service worker to work : if presents, these files will be included in the service worker manifest as files to cache. But such files may (and should) not be deployed to the server. Then on the client, files will be missing, then the service worker installation will fail and so all the offline feature won't work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes angular/mobile-toolkit#180
When copying the assets, the CLI includes system files (e.g. .DS_Store and Thumbs.db). As a consequence, they are included in the service worker manifest as files to cache. But such file may (and should) not be deployed to the server, then a file will be missing, then the service worker installation will fail and so all the offline feature won't work.
This PR ensure the service worker will ignore these system files.
@hansl @filipesilva