Skip to content
This repository has been archived by the owner on Apr 9, 2022. It is now read-only.

Update Build Optimizer to use TS 2.6 #299

Merged
merged 3 commits into from
Nov 27, 2017
Merged

Update Build Optimizer to use TS 2.6 #299

merged 3 commits into from
Nov 27, 2017

Conversation

clydin
Copy link
Member

@clydin clydin commented Nov 25, 2017

No description provided.

filipesilva
filipesilva previously approved these changes Nov 25, 2017
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM but at the moment the only the integration tests will really use 2.6. Unit tests will still use 2.4.

I think we should be ok to update devkit in general to use 2.6 though. Build Optimizer is the only lib inside with a runtime dependency on typescript.

@clydin @hansl WDYT?

@filipesilva filipesilva self-assigned this Nov 25, 2017
@filipesilva
Copy link
Contributor

filipesilva commented Nov 25, 2017 •
edited
Loading

This PR should fix angular/angular-cli#7110, angular/angular-cli#8615.

This was referenced Nov 25, 2017
Closed
Closed
@filipesilva
Copy link
Contributor

Devkit TS 2.6 update is being done separately in #300,

@filipesilva filipesilva merged commit fbd4d41 into angular:master Nov 27, 2017
@clydin clydin deleted the bo-ts2.6 branch November 27, 2017 13:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees

@filipesilva filipesilva

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clydin @filipesilva @googlebot