Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

fxHide breaks style of non-"display: box" elements #141

@netmikey

Description

@netmikey

As part of a responsive UI, there are times when we want to hide some elements of our UI (not whole parts, just a bunch of elements e.g. an item's label) on small screens.

As an example, I'd expect the following to work so that on non-xs screens, it displays the label inline next to the icon, and on xs screens only the icon remains:

<div>
    <img src="icon.png">
    <span fxHide.xs>Label</span>
</div>

The show/hide functionality now works as of v2.0.0-beta.4, but it looks like it toggles only between display: none and display: block, ignoring the actual display mode the element was in before fxHide got applied.

I think fxHide should take into account the element's actual display mode and not interfere with it.

Metadata

Metadata

Labels

P0Critical issue that needs to be resolved immediatelybughas prA PR has been created to address this issue

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions