Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): support custom breakpoints #5

Closed
ThomasBurleson opened this issue Nov 28, 2015 · 9 comments
Closed

feat(api): support custom breakpoints #5

ThomasBurleson opened this issue Nov 28, 2015 · 9 comments
Assignees
Labels
Milestone

Comments

@ThomasBurleson
Copy link
Contributor

Add ability to modify existing breakpoints (change, add, remove)

@ThomasBurleson ThomasBurleson added this to the v1.0.0-beta.2 milestone Dec 14, 2016
@ThomasBurleson ThomasBurleson self-assigned this Dec 14, 2016
@ThomasBurleson ThomasBurleson changed the title support custom breakpoints feat(api): support custom breakpoints Dec 15, 2016
@TylerDev6
Copy link

does this exist yet? Is there an example of it?

@TylerDev6
Copy link

I'm really waiting on this feature here.... any way I can help with it?

@ThomasBurleson
Copy link
Contributor Author

This feature is already available. See:

@TylerDev6
Copy link

TylerDev6 commented Feb 6, 2017

are you missing an export?

export * from './breakpoints/break-point';

@ThomasBurleson
Copy link
Contributor Author

@TylerDev6 - I do not understand what you are saying.

@TylerDev6
Copy link

I was getting a compiler error since BreakPoint was not exported from the index.d.ts file... that's how I corrected it.

@ThomasBurleson
Copy link
Contributor Author

ThomasBurleson commented Feb 6, 2017

Ah... You are correct. The BreakPoint interface is not currently exported as part of the barrel if you want to use that interface in application code or in custom breakpoint usages. This has been fixed in PR #158

@TylerDev6
Copy link

Ok, perfect. Thanks. I'm having a few other minor issues but I've already got one ticket open, so I may just add to that.

#135

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants