-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[resolved] RxJS 6.3.0 breaks angular flex layout #827
Comments
Same, also reverted to 6.2.2 to fix the build. |
@skiabox what version of |
So here's the rub: RxJS v6.3 introduced a change to the I've patched this in #828 and once it gets merged we will cut the beta 18 release (likely early tomorrow). Apologies to everyone for the inconvenience. The workaround until then is to downgrade RxJS to v6.2. |
Although this issue is fixed, I'm going to reopen it until the new release has been published for visibility. |
Can confirm and thanks for the quick fix in. #828 |
Thank for this, I still waiting for the the new release has been published |
I am having the same issue with rxjs at 6.2.2 and flex-layout at 6.0.0-beta.16
|
I've updated rxjs to 6.3 and Typescript to 2.9 but still not working, tried also downgrading to 6.0.0-beta.16 but still not working. Seems like the fix is not released yet! Any update on this issue please ? |
@bloodymind I updated to rxjs 6.3 and then downgraded again to rxjs 6.0.0. Weird but it worked for me |
@sahilt75, Please share all dependencies and devDependencies |
Version 6.0.0-beta.18 has been published on NPM. Please update to resolve this issue. |
With the beta.18 release I now see this error:
|
+1. Same issue as jgeiger-cr |
Please provide a minimal reproduction, I'm not seeing this on our internal tests. Also please try a clean uninstall/reinstall. |
Sorry, I'm using TS ~2.7.2, Angular ^6.1.6, and already tried a fresh NPM install. |
Not sure if it's related to the same issue but I did a clean install with npm instead of Yarn and it built fine |
I just installed it successfully on our StackBlitz online (tried with both TS 2.7.2 and TS 2.9.2). If you're facing an install/build issue after upgrading, it's likely the install step didn't work correctly. |
after updating the version number for flex-layout in package.json, the following worked for me: P.S. I kept RXJS @ 6.3.1 and it still worked |
Ok I see it now. The However, it might be the case that this is the terminal stage in our support for TS 2.7 (ie if you want to use RxJS 6.3, you also need to bump to TS 2.9). |
Not for me. ng -build --prod produce that error Angular CLI: 6.2.1 Package Version@angular-devkit/architect 0.8.1 |
Sorry, I don't have any idea about how it works on Linux OS. Did you try
the solution in #831.
…On Sat, 15 Sep 2018, 9:15 pm Pascal DeMilly, ***@***.***> wrote:
Not for me. ng -build --prod produce that error
Angular CLI: 6.2.1
Node: 8.9.1
OS: linux x64
Angular: 6.1.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router
Package Version
@angular-devkit/architect 0.8.1
@angular-devkit/build-angular 0.8.1
@angular-devkit/build-optimizer 0.8.1
@angular-devkit/build-webpack 0.8.1
@angular-devkit/core 0.8.1
@angular-devkit/schematics 0.8.1
@angular/cdk 6.4.7
@angular/cli 6.2.1
@angular/fire 5.0.0
@angular/flex-layout 6.0.0-beta.18
@angular/material 6.4.7
@ngtools/webpack 6.2.1
@schematics/angular 0.8.1
@schematics/update 0.8.1
rxjs 6.3.2
typescript 2.9.2
webpack 4.18.1
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#827 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AjS-xsmV8aFIWFnEeqE8xV0PixGXnA9Qks5ubSCMgaJpZM4WTslk>
.
|
Try |
locking rxjs at 6.6.2 worked for me with everything else up to date (disregarding typescript at 2.9.2 still) |
I updated from Angular 5 to 6 and can't get flex-layout working. I've been going through this list of versions and can't seem to get a combination that works. I'm using systemjs and get the error: Unexpected token < Evaluating .../node_modules/@angular/flex-layout/bundles/flex-layout.umd.js/core . It works if I bundle it, but not through systemjs. package.json systemjs.config.js
})(this); |
Did you replace the version of rxjs@6.3.1 and re-installed it? |
I manually changed the typescript version in angular.json file to 2.9.2 and run npm install, it fixed me the issue. May be it was with the TS version. |
i had the same issue, so i uninstalled version 6.0.0-beta.18 and install de version 6.0.0-beta.16 and solve the problem o/ |
@alvipeo It is working with rxjs@^6.3.2 + @angular/flex-layout@^6.0.0-beta.18. |
Works for me with following versions on Arch: Thanks for the help everyone. |
For me it worked on MacOS: |
@alvipeo |
@whitewaves For me it was from migration which caused the issue as angular.json was not avaliable and had to manually change it from angular-cli.json. I think its a more of a angular-rxjs integration issue. |
I was on flex 15 before, now the 18 compiles but my layouts are mostrly broken and wrong. Is this my fault? Do I need to fix everything by hand? |
This needs more visibility |
Windows 10 under cmder worked for me I then tried npm install rxjs-compat@latest and then it broke again. I had then to do npm install rxjs-compat@6.1.0 and downgrade flexlayout again to npm install @angular/flex-layout@6.0.0-beta.18 "@angular/flex-layout": "^7.0.0-beta.19", remains now a no go area I run Cesium in angular the procedure leaves me with a 90% Frame rate loss on Dual Titan Maxwell. From 60 fps to 6. Deleting two mat tables increases the performance. |
Same happened to me this afternoon. Should I just put everything back to beta.15 and wait for a long term fix, what do you think? Using 6.2.2 rxjs with ~2.9.2 TS and 6.0.0-beta.15 flex-layout solves the error and the broken layout also. |
Now that it's been a good three weeks since this has cropped up, I'm going to close this issue. I hope it helped everyone who came across it resolve any issues with their app. I'd also like to apologize to those people who ran into issues repeatedly, I know this hurts the user experience and is not ideal. In the future, we'll probably look into scoping TypeScript version distributions in package.json, but this may be a little ways out in terms of development. |
this worked for me too ! |
Flex-layout in versions 7.0.0-beta.20 and higher replaced ObservableMedia with MediaObserver. "media-observer: ObservableMedia is now deprecated in anticipation of RxJS v7. The new API is called MediaObserver, and provides the exact same functionality as ObservableMedia, except you cannot directly subscribe to it, After I made that change, it worked with no issues on the latest versions as of today: |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I just tried to use rxjs 6.3.0 and it seems that it breaks angular flex-layout so I returned to RxJS 6.2.2
The text was updated successfully, but these errors were encountered: