Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resolved] RxJS 6.3.0 breaks angular flex layout #827

Closed
skiabox opened this issue Aug 30, 2018 · 79 comments · Fixed by #828
Closed

[resolved] RxJS 6.3.0 breaks angular flex layout #827

skiabox opened this issue Aug 30, 2018 · 79 comments · Fixed by #828
Assignees
Labels
bug has pr A PR has been created to address this issue P0 Critical issue that needs to be resolved immediately

Comments

@skiabox
Copy link

skiabox commented Aug 30, 2018

I just tried to use rxjs 6.3.0 and it seems that it breaks angular flex-layout so I returned to RxJS 6.2.2

@bhundven
Copy link

bhundven commented Aug 30, 2018

ERROR in node_modules/@angular/flex-layout/core/typings/observable-media/observable-media.d.ts(11,14): error TS2416: Property 'subscribe' in type 'ObservableMedia' is not assignable to the same property in base type 'Subscribable<MediaChange>'.
  Type '(next?: (value: MediaChange) => void, error?: (error: any) => void, complete?: () => void) => Sub...' is not assignable to type '{ (observer?: PartialObserver<MediaChange>): Unsubscribable; (next?: (value: MediaChange) => void...'.
    Types of parameters 'next' and 'observer' are incompatible.
      Type 'PartialObserver<MediaChange>' is not assignable to type '(value: MediaChange) => void'.
        Type 'NextObserver<MediaChange>' is not assignable to type '(value: MediaChange) => void'.
          Type 'NextObserver<MediaChange>' provides no match for the signature '(value: MediaChange): void'.

Same, also reverted to 6.2.2 to fix the build.

@lexcaraig
Copy link

@skiabox what version of @angular/flex-layout are you using? Bec, I'm getting the same error. Thanks.

@CaerusKaru
Copy link
Member

So here's the rub: RxJS v6.3 introduced a change to the Subscribable interface, which is what ObservableMedia extends. As a result, the type errors you've all been getting have surfaced leading to the bad builds.

I've patched this in #828 and once it gets merged we will cut the beta 18 release (likely early tomorrow). Apologies to everyone for the inconvenience. The workaround until then is to downgrade RxJS to v6.2.

@CaerusKaru CaerusKaru added bug has pr A PR has been created to address this issue P0 Critical issue that needs to be resolved immediately labels Aug 31, 2018
@CaerusKaru CaerusKaru added this to the v6.0.0-beta.18 milestone Aug 31, 2018
@CaerusKaru CaerusKaru self-assigned this Aug 31, 2018
ThomasBurleson pushed a commit that referenced this issue Aug 31, 2018
* build: update to TypeScript 2.9 and RxJS 6.3

Fixes #828, Fixes #827.
@CaerusKaru
Copy link
Member

Although this issue is fixed, I'm going to reopen it until the new release has been published for visibility.

@CaerusKaru CaerusKaru reopened this Aug 31, 2018
@x7even
Copy link

x7even commented Aug 31, 2018

Can confirm and thanks for the quick fix in. #828

@vuthanhvien
Copy link

Thank for this, I still waiting for the the new release has been published

@dale-french
Copy link

I am having the same issue with rxjs at 6.2.2 and flex-layout at 6.0.0-beta.16

ERROR in node_modules/@angular/flex-layout/core/typings/observable-media/observable-media.d.ts(11,14): error TS2416: Property 'subscribe' in type 'ObObservableMedia' is not assignable to the same property in base type 'Subscribable<MediaChange>'.

@soufiane-fadil
Copy link

soufiane-fadil commented Aug 31, 2018

I've updated rxjs to 6.3 and Typescript to 2.9 but still not working, tried also downgrading to 6.0.0-beta.16 but still not working.

Seems like the fix is not released yet! Any update on this issue please ?

@sahilt75
Copy link

@bloodymind I updated to rxjs 6.3 and then downgraded again to rxjs 6.0.0. Weird but it worked for me

@mkginfo
Copy link

mkginfo commented Aug 31, 2018

@sahilt75, Please share all dependencies and devDependencies

@CaerusKaru
Copy link
Member

Version 6.0.0-beta.18 has been published on NPM. Please update to resolve this issue.

@jgeiger-cr
Copy link

jgeiger-cr commented Aug 31, 2018

With the beta.18 release I now see this error:

ERROR in node_modules/@angular/flex-layout/extended/typings/style/style.d.ts(72,67): error TS1144: '{' or ';' expected.
node_modules/@angular/flex-layout/extended/typings/style/style.d.ts(74,5): error TS1128: Declaration or statement expected.
node_modules/@angular/flex-layout/extended/typings/style/style.d.ts(74,33): error TS1005: ';' expected.
node_modules/@angular/flex-layout/extended/typings/style/style.d.ts(74,39): error TS1109: Expression expected.
node_modules/@angular/flex-layout/extended/typings/style/style.d.ts(79,5): error TS1128: Declaration or statement expected.
node_modules/@angular/flex-layout/extended/typings/style/style.d.ts(80,1): error TS1128: Declaration or statement expected.

@jrosseel
Copy link

+1. Same issue as jgeiger-cr

@CaerusKaru
Copy link
Member

Please provide a minimal reproduction, I'm not seeing this on our internal tests. Also please try a clean uninstall/reinstall.

@jgeiger-cr
Copy link

jgeiger-cr commented Aug 31, 2018

Sorry, I'm using TS ~2.7.2, Angular ^6.1.6, and already tried a fresh NPM install.

@dale-french
Copy link

Not sure if it's related to the same issue but I did a clean install with npm instead of Yarn and it built fine

@CaerusKaru
Copy link
Member

I just installed it successfully on our StackBlitz online (tried with both TS 2.7.2 and TS 2.9.2). If you're facing an install/build issue after upgrading, it's likely the install step didn't work correctly.

@sheariley
Copy link

sheariley commented Aug 31, 2018

after updating the version number for flex-layout in package.json, the following worked for me:
npm install reinstall @angular/flex-layout

P.S. I kept RXJS @ 6.3.1 and it still worked

@jgeiger-cr
Copy link

jgeiger-cr commented Aug 31, 2018

4 of our developers independently see the same problem with fresh NPM installs on Macs, Windows, Linux. Even IntelliJ sees the errors in node_modules/@angular/flex-layout/extended/typings/style/style.d.ts

flex error

@CaerusKaru
Copy link
Member

Ok I see it now. The import syntax is new for TS, and only works with TS 2.9. The workaround is to bump to TS 2.9 as well while we consider options internally.

However, it might be the case that this is the terminal stage in our support for TS 2.7 (ie if you want to use RxJS 6.3, you also need to bump to TS 2.9).

@pdemilly
Copy link

Not for me. ng -build --prod produce that error

Angular CLI: 6.2.1
Node: 8.9.1
OS: linux x64
Angular: 6.1.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.8.1
@angular-devkit/build-angular 0.8.1
@angular-devkit/build-optimizer 0.8.1
@angular-devkit/build-webpack 0.8.1
@angular-devkit/core 0.8.1
@angular-devkit/schematics 0.8.1
@angular/cdk 6.4.7
@angular/cli 6.2.1
@angular/fire 5.0.0
@angular/flex-layout 6.0.0-beta.18
@angular/material 6.4.7
@ngtools/webpack 6.2.1
@schematics/angular 0.8.1
@schematics/update 0.8.1
rxjs 6.3.2
typescript 2.9.2
webpack 4.18.1

@ghost
Copy link

ghost commented Sep 15, 2018 via email

@odahcam
Copy link

odahcam commented Sep 15, 2018

Try ng update --all

@bostondevin
Copy link

locking rxjs at 6.6.2 worked for me with everything else up to date (disregarding typescript at 2.9.2 still)

@codemonkey00
Copy link

I updated from Angular 5 to 6 and can't get flex-layout working. I've been going through this list of versions and can't seem to get a combination that works. I'm using systemjs and get the error: Unexpected token < Evaluating .../node_modules/@angular/flex-layout/bundles/flex-layout.umd.js/core . It works if I bundle it, but not through systemjs.

package.json
"dependencies": { "@angular/animations": "6.1.7", "@angular/cdk": "6.4.7", "@angular/cli": "1.7.3", "@angular/common": "6.1.7", "@angular/compiler": "6.1.7", "@angular/compiler-cli": "6.1.7", "@angular/core": "6.1.7", "@angular/flex-layout": "6.0.0-beta.18", "@angular/forms": "6.1.7", "@angular/http": "6.1.7", "@angular/material": "6.4.7", "@angular/platform-browser": "6.1.7", "@angular/platform-browser-dynamic": "6.1.7", "@angular/platform-server": "6.1.7", "@angular/router": "6.1.7", "@angular/upgrade": "6.1.7", "animate.css": "3.7.0", "bootstrap": "3.3.7", "classlist.js": "1.1.20150312", "core-js": "2.5.7", "glob": "7.1.2", "intl": "1.2.5", "jquery": "3.3.1", "rxjs": "6.3.2", "rxjs-compat": "6.3.2", "systemjs": "0.21.4", "typescript": "2.9.2", "web-animations-js": "2.3.1", "zone.js": "0.8.26" }

systemjs.config.js
`(function (global) {
System.config({
paths: {
// paths serve as alias
'npm:': 'node_modules/'
},
// map tells the System loader where to look for things
map: {
// our app is within the app folder
app: 'app',

        // angular bundles
        '@angular/animations': 'npm:@angular/animations/bundles/animations.umd.js',
        '@angular/animations/browser': 'npm:@angular/animations/bundles/animations-browser.umd.js',
        '@angular/common': 'npm:@angular/common/bundles/common.umd.js',
        '@angular/common/http': 'npm:@angular/common/bundles/common-http.umd.js',
        '@angular/compiler': 'npm:@angular/compiler/bundles/compiler.umd.js',
        '@angular/core': 'npm:@angular/core/bundles/core.umd.js',
        '@angular/http': 'npm:@angular/http/bundles/http.umd.js',
        '@angular/flex-layout': 'npm:@angular/flex-layout/bundles/flex-layout.umd.js',
        '@angular/forms': 'npm:@angular/forms/bundles/forms.umd.js',
        '@angular/material': 'npm:@angular/material/bundles/material.umd.js',
        '@angular/platform-browser': 'npm:@angular/platform-browser/bundles/platform-browser.umd.js',
        '@angular/platform-browser/animations': 'npm:@angular/platform-browser/bundles/platform-browser-animations.umd.js',
        '@angular/platform-browser-dynamic': 'npm:@angular/platform-browser-dynamic/bundles/platform-browser-dynamic.umd.js',
        "@angular/platform-server": 'npm:@angular/platform-server/bundles/platform-server.umd.js',
        '@angular/router': 'npm:@angular/router/bundles/router.umd.js',
        '@angular/upgrade': 'npm:@angular/upgrade/bundles/upgrade.umd.js',
        '@angular/upgrade/static': 'npm:@angular/upgrade/bundles/upgrade-static.umd.js',

        //cdk
        '@angular/cdk': 'npm:@angular/cdk/bundles/cdk.umd.js', 
        '@angular/cdk/a11y': 'npm:/@angular/cdk/bundles/cdk-a11y.umd.js',
        '@angular/cdk/accordion': 'npm:/@angular/cdk/bundles/cdk-accordion.umd.js',
        '@angular/cdk/bidi': 'npm:/@angular/cdk/bundles/cdk-bidi.umd.js',
        '@angular/cdk/coercion': 'npm:/@angular/cdk/bundles/cdk-coercion.umd.js',
        '@angular/cdk/collections': 'npm:/@angular/cdk/bundles/cdk-collections.umd.js',
        '@angular/cdk/keycodes': 'npm:/@angular/cdk/bundles/cdk-keycodes.umd.js',
        '@angular/cdk/layout': 'npm:/@angular/cdk/bundles/cdk-layout.umd.js',
        '@angular/cdk/observers': 'npm:/@angular/cdk/bundles/cdk-observers.umd.js',
        '@angular/cdk/overlay': 'npm:/@angular/cdk/bundles/cdk-overlay.umd.js',
        '@angular/cdk/platform': 'npm:/@angular/cdk/bundles/cdk-platform.umd.js',
        '@angular/cdk/portal': 'npm:/@angular/cdk/bundles/cdk-portal.umd.js',
        '@angular/cdk/scrolling': 'npm:/@angular/cdk/bundles/cdk-scrolling.umd.js',
        '@angular/cdk/stepper': 'npm:/@angular/cdk/bundles/cdk-stepper.umd.js',
        '@angular/cdk/table': 'npm:/@angular/cdk/bundles/cdk-table.umd.js',
        '@angular/cdk/text-field': 'npm:/@angular/cdk/bundles/cdk-text-field.umd.js',
        '@angular/cdk/tree': 'npm:/@angular/cdk/bundles/cdk-tree.umd.js',

        'jquery': 'npm:jquery/dist/jquery.js',
        'rxjs': 'npm:rxjs',
        'rxjs/operators': 'npm:rxjs/operators',
        'tslib': 'npm:tslib/tslib.js'
    },
    // packages tells the System loader how to load when no filename and/or no extension
    packages: {
        app: {
            main: './main.js', defaultExtension: 'js',
            meta: { './*.js': { loader: 'systemjs-angular-loader.js' } }
        },
        'rxjs': { main: 'index.js', defaultExtension: 'js' },
        'rxjs/operators': { main: 'index.js', defaultExtension: 'js' },
        'jquery': { defaultExtension: 'js' }            
    }
});

})(this);
`

@V5NEXT
Copy link

V5NEXT commented Sep 20, 2018

after updating the version number for flex-layout in package.json, the following worked for me:
npm install reinstall @angular/flex-layout

P.S. I kept RXJS @ 6.3.1 and it still worked

Did you replace the version of rxjs@6.3.1 and re-installed it?

@V5NEXT
Copy link

V5NEXT commented Sep 20, 2018

I updated from Angular 5 to 6 and can't get flex-layout working. I've been going through this list of versions and can't seem to get a combination that works. I'm using systemjs and get the error: Unexpected token < Evaluating .../node_modules/@angular/flex-layout/bundles/flex-layout.umd.js/core . It works if I bundle it, but not through systemjs.

package.json
"dependencies": { "@angular/animations": "6.1.7", "@angular/cdk": "6.4.7", "@angular/cli": "1.7.3", "@angular/common": "6.1.7", "@angular/compiler": "6.1.7", "@angular/compiler-cli": "6.1.7", "@angular/core": "6.1.7", "@angular/flex-layout": "6.0.0-beta.18", "@angular/forms": "6.1.7", "@angular/http": "6.1.7", "@angular/material": "6.4.7", "@angular/platform-browser": "6.1.7", "@angular/platform-browser-dynamic": "6.1.7", "@angular/platform-server": "6.1.7", "@angular/router": "6.1.7", "@angular/upgrade": "6.1.7", "animate.css": "3.7.0", "bootstrap": "3.3.7", "classlist.js": "1.1.20150312", "core-js": "2.5.7", "glob": "7.1.2", "intl": "1.2.5", "jquery": "3.3.1", "rxjs": "6.3.2", "rxjs-compat": "6.3.2", "systemjs": "0.21.4", "typescript": "2.9.2", "web-animations-js": "2.3.1", "zone.js": "0.8.26" }

systemjs.config.js
`(function (global) {
System.config({
paths: {
// paths serve as alias
'npm:': 'node_modules/'
},
// map tells the System loader where to look for things
map: {
// our app is within the app folder
app: 'app',

        // angular bundles
        '@angular/animations': 'npm:@angular/animations/bundles/animations.umd.js',
        '@angular/animations/browser': 'npm:@angular/animations/bundles/animations-browser.umd.js',
        '@angular/common': 'npm:@angular/common/bundles/common.umd.js',
        '@angular/common/http': 'npm:@angular/common/bundles/common-http.umd.js',
        '@angular/compiler': 'npm:@angular/compiler/bundles/compiler.umd.js',
        '@angular/core': 'npm:@angular/core/bundles/core.umd.js',
        '@angular/http': 'npm:@angular/http/bundles/http.umd.js',
        '@angular/flex-layout': 'npm:@angular/flex-layout/bundles/flex-layout.umd.js',
        '@angular/forms': 'npm:@angular/forms/bundles/forms.umd.js',
        '@angular/material': 'npm:@angular/material/bundles/material.umd.js',
        '@angular/platform-browser': 'npm:@angular/platform-browser/bundles/platform-browser.umd.js',
        '@angular/platform-browser/animations': 'npm:@angular/platform-browser/bundles/platform-browser-animations.umd.js',
        '@angular/platform-browser-dynamic': 'npm:@angular/platform-browser-dynamic/bundles/platform-browser-dynamic.umd.js',
        "@angular/platform-server": 'npm:@angular/platform-server/bundles/platform-server.umd.js',
        '@angular/router': 'npm:@angular/router/bundles/router.umd.js',
        '@angular/upgrade': 'npm:@angular/upgrade/bundles/upgrade.umd.js',
        '@angular/upgrade/static': 'npm:@angular/upgrade/bundles/upgrade-static.umd.js',

        //cdk
        '@angular/cdk': 'npm:@angular/cdk/bundles/cdk.umd.js', 
        '@angular/cdk/a11y': 'npm:/@angular/cdk/bundles/cdk-a11y.umd.js',
        '@angular/cdk/accordion': 'npm:/@angular/cdk/bundles/cdk-accordion.umd.js',
        '@angular/cdk/bidi': 'npm:/@angular/cdk/bundles/cdk-bidi.umd.js',
        '@angular/cdk/coercion': 'npm:/@angular/cdk/bundles/cdk-coercion.umd.js',
        '@angular/cdk/collections': 'npm:/@angular/cdk/bundles/cdk-collections.umd.js',
        '@angular/cdk/keycodes': 'npm:/@angular/cdk/bundles/cdk-keycodes.umd.js',
        '@angular/cdk/layout': 'npm:/@angular/cdk/bundles/cdk-layout.umd.js',
        '@angular/cdk/observers': 'npm:/@angular/cdk/bundles/cdk-observers.umd.js',
        '@angular/cdk/overlay': 'npm:/@angular/cdk/bundles/cdk-overlay.umd.js',
        '@angular/cdk/platform': 'npm:/@angular/cdk/bundles/cdk-platform.umd.js',
        '@angular/cdk/portal': 'npm:/@angular/cdk/bundles/cdk-portal.umd.js',
        '@angular/cdk/scrolling': 'npm:/@angular/cdk/bundles/cdk-scrolling.umd.js',
        '@angular/cdk/stepper': 'npm:/@angular/cdk/bundles/cdk-stepper.umd.js',
        '@angular/cdk/table': 'npm:/@angular/cdk/bundles/cdk-table.umd.js',
        '@angular/cdk/text-field': 'npm:/@angular/cdk/bundles/cdk-text-field.umd.js',
        '@angular/cdk/tree': 'npm:/@angular/cdk/bundles/cdk-tree.umd.js',

        'jquery': 'npm:jquery/dist/jquery.js',
        'rxjs': 'npm:rxjs',
        'rxjs/operators': 'npm:rxjs/operators',
        'tslib': 'npm:tslib/tslib.js'
    },
    // packages tells the System loader how to load when no filename and/or no extension
    packages: {
        app: {
            main: './main.js', defaultExtension: 'js',
            meta: { './*.js': { loader: 'systemjs-angular-loader.js' } }
        },
        'rxjs': { main: 'index.js', defaultExtension: 'js' },
        'rxjs/operators': { main: 'index.js', defaultExtension: 'js' },
        'jquery': { defaultExtension: 'js' }            
    }
});

})(this);
`

I manually changed the typescript version in angular.json file to 2.9.2 and run npm install, it fixed me the issue. May be it was with the TS version.

https://stackoverflow.com/questions/52421513/angular6-flex-layout-not-working-after-migrating-from-angular5?noredirect=1#comment91786958_52421513

@heavyrick
Copy link

i had the same issue, so i uninstalled version 6.0.0-beta.18 and install de version 6.0.0-beta.16 and solve the problem o/

@Twechy
Copy link

Twechy commented Sep 25, 2018

@alvipeo It is working with rxjs@^6.3.2 + @angular/flex-layout@^6.0.0-beta.18.

@maytanthegeek
Copy link

Works for me with following versions on Arch:
@angular/flex-layout: ^6.0.0-beta.18
rxjs: ^6.3.3
typescript: ~2.9.2

Thanks for the help everyone.

@germfy
Copy link

germfy commented Oct 2, 2018

For me it worked on MacOS:
@angular/flex-layout: 6.0.0-beta.18
RxJS: 6.3.2
typescript: 2.9.2

@whitewaves
Copy link

@alvipeo
is it with current version of angular

@V5NEXT
Copy link

V5NEXT commented Oct 4, 2018

@whitewaves For me it was from migration which caused the issue as angular.json was not avaliable and had to manually change it from angular-cli.json. I think its a more of a angular-rxjs integration issue.

@angular angular deleted a comment from anasanzari Oct 4, 2018
@Polyterative
Copy link

Polyterative commented Oct 8, 2018

I was on flex 15 before, now the 18 compiles but my layouts are mostrly broken and wrong. Is this my fault? Do I need to fix everything by hand?

@ricardosaracino
Copy link

Works for me with following versions on Arch:
@angular/flex-layout: ^6.0.0-beta.18
rxjs: ^6.3.3
typescript: ~2.9.2

Thanks for the help everyone.

This needs more visibility

@Koesters
Copy link

 typescript: ~2.9.2
"@angular/animations": "^6.1.10",
"@angular/cdk": "^6.4.7",
"@angular/common": "^6.1.10",
"@angular/compiler": "^6.1.10",
"@angular/core": "^6.1.10",
"@angular/flex-layout": "^7.0.0-beta.19",
"@angular/forms": "^6.1.10",
"@angular/http": "^6.1.10",
"@angular/material": "^6.4.7",
"@angular/platform-browser": "^6.1.10",
"@angular/platform-browser-dynamic": "^6.1.10",
"@angular/router": "^6.1.10",
"rxjs": "^6.3.3",
"rxjs-compat": "^6.1.0",

Windows 10 under cmder worked for me
ricardosaracino solution compiled but threw the errors in the browser (Chrome),

I then tried npm install rxjs-compat@latest

and then it broke again.

I had then to do

npm install rxjs-compat@6.1.0

and downgrade flexlayout again to

npm install @angular/flex-layout@6.0.0-beta.18

"@angular/flex-layout": "^7.0.0-beta.19", remains now a no go area

I run Cesium in angular the procedure leaves me with a 90% Frame rate loss on Dual Titan Maxwell. From 60 fps to 6.

Deleting two mat tables increases the performance.

@andrasbarabas
Copy link

andrasbarabas commented Oct 18, 2018

I was on flex 15 before, now the 18 compiles but my layouts are mostrly broken and wrong. Is this my fault? Do I need to fix everything by hand?

Same happened to me this afternoon. Should I just put everything back to beta.15 and wait for a long term fix, what do you think?

Using 6.2.2 rxjs with ~2.9.2 TS and 6.0.0-beta.15 flex-layout solves the error and the broken layout also.

@CaerusKaru
Copy link
Member

Now that it's been a good three weeks since this has cropped up, I'm going to close this issue. I hope it helped everyone who came across it resolve any issues with their app.

I'd also like to apologize to those people who ran into issues repeatedly, I know this hurts the user experience and is not ideal. In the future, we'll probably look into scoping TypeScript version distributions in package.json, but this may be a little ways out in terms of development.

@dhantoot
Copy link

For me it worked on MacOS:
@angular/flex-layout: 6.0.0-beta.18
RxJS: 6.3.2
typescript: 2.9.2

this worked for me too !

@malinka007
Copy link

Flex-layout in versions 7.0.0-beta.20 and higher replaced ObservableMedia with MediaObserver.

"media-observer: ObservableMedia is now deprecated in anticipation of RxJS v7. The new API is called MediaObserver, and provides the exact same functionality as ObservableMedia, except you cannot directly subscribe to it,
Developers should subscribe to MediaObserver's media$ property; in place of subscribing directly to ObservableMedia." taken from https://github.com/angular/flex-layout/blob/master/CHANGELOG.

After I made that change, it worked with no issues on the latest versions as of today:
"@angular/core": "^7.1.1",
"@angular/flex-layout": "^7.0.0-beta.23",
"rxjs": "^6.3.3",
"rxjs-compat": "^6.3.3",

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug has pr A PR has been created to address this issue P0 Critical issue that needs to be resolved immediately
Projects
None yet
Development

Successfully merging a pull request may close this issue.