Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular dependency in show/hide #88

Closed
jelbourn opened this issue Jan 4, 2017 · 2 comments
Closed

Circular dependency in show/hide #88

jelbourn opened this issue Jan 4, 2017 · 2 comments
Assignees
@joshwiens
Labels
bug

Comments

@jelbourn
Copy link
Member

jelbourn commented Jan 4, 2017

The show and hide directives import each other, creating a circular dependency that needs to be resolved.

The tool madge can be used to detect circular changes; on the material2 repo we have this as a CI check.
@joshwiens joshwiens added the bug label Jan 4, 2017
@joshwiens joshwiens self-assigned this Jan 4, 2017
@joshwiens
Copy link
Contributor

It's part of the linting if I remember correctly. I'll get it added to the validations after 16:00 ( short work day ftw )

joshwiens added a commit to joshwiens/flex-layout that referenced this issue Jan 4, 2017
@joshwiens
ci(Travis): angular#88 enable circular dependency checks
3f1632d 
 - adds lint to travis matrix
 - enables mode in build-and-test.sh
 - updates madge to 1.4.4
   - changes from 0.6.0 to 1.4.4 done effect usage
 - updates yarn lock file accordingly
joshwiens added a commit to joshwiens/flex-layout that referenced this issue Jan 4, 2017
@joshwiens
ci(Travis): angular#88 enable circular dependency checks
4f445c9 
 - adds lint to travis matrix
 - enables mode in build-and-test.sh
 - updates madge to 1.4.4
   - changes from 0.6.0 to 1.4.4 don't effect usage
 - updates yarn lock file accordingly
joshwiens added a commit to joshwiens/flex-layout that referenced this issue Jan 5, 2017
@joshwiens
ci(Travis): angular#88 enable circular dependency checks
7f648df 
 - adds lint to travis matrix
 - enables mode in build-and-test.sh
 - updates madge to 1.4.4
   - changes from 0.6.0 to 1.4.4 don't effect usage
 - updates yarn lock file accordingly
@joshwiens joshwiens mentioned this issue Jan 5, 2017
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joshwiens joshwiens

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jelbourn @joshwiens