-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular dependency in show/hide #88
Labels
Comments
It's part of the linting if I remember correctly. I'll get it added to the validations after 16:00 ( short work day ftw ) |
joshwiens
added a commit
to joshwiens/flex-layout
that referenced
this issue
Jan 4, 2017
- adds lint to travis matrix - enables mode in build-and-test.sh - updates madge to 1.4.4 - changes from 0.6.0 to 1.4.4 done effect usage - updates yarn lock file accordingly
joshwiens
added a commit
to joshwiens/flex-layout
that referenced
this issue
Jan 4, 2017
- adds lint to travis matrix - enables mode in build-and-test.sh - updates madge to 1.4.4 - changes from 0.6.0 to 1.4.4 don't effect usage - updates yarn lock file accordingly
joshwiens
added a commit
to joshwiens/flex-layout
that referenced
this issue
Jan 5, 2017
- adds lint to travis matrix - enables mode in build-and-test.sh - updates madge to 1.4.4 - changes from 0.6.0 to 1.4.4 don't effect usage - updates yarn lock file accordingly
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The show and hide directives import each other, creating a circular dependency that needs to be resolved.
The tool madge can be used to detect circular changes; on the material2 repo we have this as a CI check.
The text was updated successfully, but these errors were encountered: