Fix SSR build: check null _document.defaultView #1325

dodongphure · 2021-03-22T16:55:53Z

CaerusKaru · 2021-03-29T04:04:42Z

For some reason SauceLabs is deciding to flake out on every run. I'll investigate this and try to get it to pass later this week. Thanks for the contribution!

Update to new saucelabs account.

CaerusKaru · 2021-03-30T19:51:03Z

@dodongphure ok CI should be resolved now, can you rebase from master?

Update the version of the sauceconnect binary used to the latest version.

Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.16.2 to 10.4.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md) - [Commits](highlightjs/highlight.js@9.16.2...10.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Update to new saucelabs account.

Update the version of the sauceconnect binary used to the latest version.

Bumps [highlight.js](https://github.com/highlightjs/highlight.js) from 9.16.2 to 10.4.1. - [Release notes](https://github.com/highlightjs/highlight.js/releases) - [Changelog](https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md) - [Commits](highlightjs/highlight.js@9.16.2...10.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [y18n](https://github.com/yargs/y18n) from 3.2.1 to 3.2.2. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

google-cla · 2021-04-04T08:50:01Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-04T08:55:56Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2021-04-04T08:56:41Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

dodongphure · 2021-04-04T08:58:34Z

@googlebot I consent

google-cla · 2021-04-04T08:58:41Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

CaerusKaru · 2021-04-04T13:10:33Z

@dodongphure Your PR is in a bad state; your rebase was unsuccessful it looks like. Please make sure you have pulled from origin/master and rebased instead of just doing git pull.

…ayout into fix_ssr_build

google-cla · 2021-04-04T15:02:32Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

dodongphure · 2021-04-04T15:13:33Z

Sorry close this and opened new pull #1337.

angular-automatic-lock-bot · 2021-05-05T12:03:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Fix SSR build: check null _document.defaultView

73cd779

google-cla bot added the cla: yes label Mar 22, 2021

CaerusKaru added pr: lgtm This PR has been approved by the reviewer ssr pr: merge ready This PR is ready for the caretaker to presubmit and merge labels Mar 29, 2021

CaerusKaru approved these changes Mar 29, 2021

View reviewed changes

CaerusKaru added pr: on hold and removed pr: merge ready This PR is ready for the caretaker to presubmit and merge labels Mar 29, 2021

ci: update saucelabs informaion (angular#1332)

7580662

Update to new saucelabs account.

CaerusKaru and others added 9 commits March 30, 2021 14:51

ci: update sauceconnect verstion to 4.6.2 (angular#1331)

623bc14

Update the version of the sauceconnect binary used to the latest version.

ci: update saucelabs informaion (angular#1332)

40875e1

Update to new saucelabs account.

ci: update sauceconnect verstion to 4.6.2 (angular#1331)

a12ae12

Update the version of the sauceconnect binary used to the latest version.

google-cla bot added cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: yes labels Apr 4, 2021

dodongphure requested a review from CaerusKaru April 4, 2021 09:02

Fix SSR build: check null _document.defaultView

8ccaad4

Merge branch 'fix_ssr_build' of https://github.com/dodongphure/flex-l…

ac83cbf

…ayout into fix_ssr_build

dodongphure closed this Apr 4, 2021

dodongphure deleted the fix_ssr_build branch April 4, 2021 15:05

dodongphure mentioned this pull request Apr 4, 2021

Fix SSR build: check null _document.defaultView #1337

Merged

angular-automatic-lock-bot bot locked and limited conversation to collaborators May 5, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix SSR build: check null _document.defaultView #1325

Fix SSR build: check null _document.defaultView #1325

Uh oh!

dodongphure commented Mar 22, 2021

Uh oh!

CaerusKaru commented Mar 29, 2021

Uh oh!

CaerusKaru commented Mar 30, 2021

Uh oh!

google-cla bot commented Apr 4, 2021

Uh oh!

google-cla bot commented Apr 4, 2021

Uh oh!

google-cla bot commented Apr 4, 2021

Uh oh!

dodongphure commented Apr 4, 2021

Uh oh!

google-cla bot commented Apr 4, 2021

Uh oh!

CaerusKaru commented Apr 4, 2021

Uh oh!

google-cla bot commented Apr 4, 2021

Uh oh!

dodongphure commented Apr 4, 2021

Uh oh!

angular-automatic-lock-bot bot commented May 5, 2021

Uh oh!

Uh oh!

Fix SSR build: check null _document.defaultView #1325

Fix SSR build: check null _document.defaultView #1325

Uh oh!

Conversation

dodongphure commented Mar 22, 2021

Uh oh!

CaerusKaru commented Mar 29, 2021

Uh oh!

CaerusKaru commented Mar 30, 2021

Uh oh!

google-cla bot commented Apr 4, 2021

Uh oh!

google-cla bot commented Apr 4, 2021

Uh oh!

google-cla bot commented Apr 4, 2021

Uh oh!

dodongphure commented Apr 4, 2021

Uh oh!

google-cla bot commented Apr 4, 2021

Uh oh!

CaerusKaru commented Apr 4, 2021

Uh oh!

google-cla bot commented Apr 4, 2021

Uh oh!

dodongphure commented Apr 4, 2021

Uh oh!

angular-automatic-lock-bot bot commented May 5, 2021

Uh oh!

Uh oh!