Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flexbox): allow directives to be easily extended #163

Merged
merged 1 commit into from
Feb 9, 2017

Conversation

ThomasBurleson
Copy link
Contributor

No description provided.

@ThomasBurleson
Copy link
Contributor Author

TODO - rebase after PR #158 has been merged.

@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.5 milestone Feb 7, 2017
@ThomasBurleson ThomasBurleson self-assigned this Feb 7, 2017
@ThomasBurleson ThomasBurleson force-pushed the wip/thomas/extendable-directives branch 2 times, most recently from cbcb5d0 to 50dd4e7 Compare February 8, 2017 14:30
@ThomasBurleson ThomasBurleson added pr: lgtm This PR has been approved by the reviewer pr: needs presubmit and removed in-progress pr: needs rebase labels Feb 8, 2017
…ily extended

* change internal methods to `protected` to enable subclass access
> Useful when extending directives with custom breakpoints.
@tinayuangao tinayuangao merged commit e6bc451 into master Feb 9, 2017
@ThomasBurleson ThomasBurleson deleted the wip/thomas/extendable-directives branch February 9, 2017 14:34
karlhaas pushed a commit to karlhaas/flex-layout that referenced this pull request May 3, 2017
…ily extended (angular#163)

* change internal methods to `protected` to enable subclass access
> Useful when extending directives with custom breakpoints.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer pr: needs presubmit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants