Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(Travis): enable circular dependency checks #91

Merged
merged 4 commits into from
Jan 5, 2017

Conversation

joshwiens
Copy link
Contributor

  • adds lint to travis matrix
  • enables mode in build-and-test.sh
  • updates madge to 1.4.4
    • changes from 0.6.0 to 1.4.4 don't effect usage in this library
    • correct forbidden-identifiers module path
    • remove e2e from sourceFolders
  • updates tslint to 4.4.0
  • updates yarn lock file accordingly

Relates to #88

 - adds lint to travis matrix
 - enables mode in build-and-test.sh
 - updates madge to 1.4.4
   - changes from 0.6.0 to 1.4.4 don't effect usage
 - updates yarn lock file accordingly
 - correct forbidden-identifiers module path
 - remove e2e from sourceFolders
@ThomasBurleson
Copy link
Contributor

@d3viant0ne - I did not know you could do these:

  • tslint:disable-line:max-line-length
  • tslint:disable-next-line:variable-name
  • tslint:disable-next-line:no-shadowed-variable
  • tslint:disable-line:no-unused-variable

That is SUPER cool!

@googlebot
Copy link
Collaborator

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: yes labels Jan 5, 2017
@ThomasBurleson ThomasBurleson merged commit 3f5a7e4 into angular:master Jan 5, 2017
@ThomasBurleson
Copy link
Contributor

@d3viant0ne - great work here!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants