This repository was archived by the owner on Feb 26, 2024. It is now read-only.
feat: make it work in node for Angular universal demos #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardbell
suggested changes
Mar 3, 2017
src/in-memory-backend.service.ts
Outdated
| return l; | ||
| // default the base url when not running in browser | ||
| let base = document ? document.location.href : 'http://node'; | ||
| return new URL(href, base); |
There was a problem hiding this comment.
@steveschmitt I'm worried that this won't work in all the browsers we support because the URL type is experimental. I'm not sure it's shimmed.
Would you please check in IE, Edge, and FF. Or come up with an alternative for producing the string we need. I don't think our use of this location stuff needs to be that complicated. I think we can do it with regEx for example.
There was a problem hiding this comment.
Works in Chrome, Firefox, and Edge, but fails in IE 11. I'll work on an alternative.
…for browser compatibility
|
Changed to a regex-based approach, without changing the dependent code. |
wardbell
approved these changes
Mar 9, 2017
wardbell
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
document.createElement('a')withnew URL();This allows running on non-browser platforms, e.g. Angular Universal.
Note that
URLneeds to be shimmed when running on IE or on node < 7, e.g.:Yes, I know it seems strange to run a fake backend on a real backend, but it helps testing.