-
Notifications
You must be signed in to change notification settings - Fork 229
Allow default behavior with HTTP interceptors #120
Conversation
Allow an HTTP interceptor method to return null to signal to the service that it should run the collection handler or the fallback handler for the request.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it!
…On Fri, Jul 7, 2017 at 6:23 PM, googlebot ***@***.***> wrote:
Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 *Please visit https://cla.developers.google.com/
<https://cla.developers.google.com/> to sign.*
Once you've signed, please reply here (e.g. I signed it!) and we'll
verify. Thanks.
------------------------------
- If you've already signed a CLA, it's possible we don't have your
GitHub username or you're using a different email address. Check your
existing CLA data <https://cla.developers.google.com/clas> and verify
that your email is set on your git commits
<https://help.github.com/articles/setting-your-email-in-git/>.
- If your company signed a CLA, they designated a Point of Contact who
decides which employees are authorized to participate. You may need to
contact the Point of Contact for your company and ask to be added to the
group of authorized contributors. If you don't know who your Point of
Contact is, direct the project maintainer to go/cla#troubleshoot.
- In order to pass this check, please resolve this problem and have
the pull request author add another comment and the bot will run again.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#120 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABJS6qMx6vjXJvI-smFBk5BvwQgjAUkaks5sLtn2gaJpZM4ORlYR>
.
|
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like your idea.
I'm refactoring heavily to support Angular's "new" HttpClient
so I can't merge your code exactly as written. I'll have to close this PR.
But I'm definitely taking it as you can see in PR #130. Thanks!
Closing for reason give in my review. See PR #130 |
- refactor to support tests - correct bugs and clarify choices as result of test - add new configuration options - POST commands/resetDb` passes the request to the `resetDb` method - when HTTP method interceptor returns null/undefined, continue with default request processing. - reorganize files into src/app and src/in-mem - adjust gulp tasks accordingly closes #123. closes #128. closes #120.
- refactor to support tests - correct bugs and clarify choices as result of test - add new configuration options - POST commands/resetDb` passes the request to the `resetDb` method - when HTTP method interceptor returns null/undefined, continue with default request processing. - reorganize files into src/app and src/in-mem - adjust gulp tasks accordingly closes #123. closes #128. closes #120.
Thanks Ward! Good luck on the refactor. |
- refactor to support tests - correct bugs and clarify choices as result of test - add new configuration options - POST commands/resetDb` passes the request to the `resetDb` method - when HTTP method interceptor returns null/undefined, continue with default request processing. - reorganize files into src/app and src/in-mem - adjust gulp tasks accordingly closes #123. closes #128. closes #120.
In our project we wanted to be able to POST to a certain path we had mocked using the in-memory-web-api, but wanted to retain the ability for POST to add collection items without having to reinvent the wheel. It was not immediately apparent if our service had access to its controlling service object to call the collectionHandler() method, so we just modified the service to accept a null return to continue default processing. Submitting here in case it is found useful to others.