Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

digitalpardoe
Copy link

Whilst issues caused by the current functionality, angular/angular#22623 or #162 for example, can be solved through the use of a custom genId it strikes me that most developers who use in-memory-web-api will:

  1. Be sufficiently experienced or dealing with a level of complexity from the start that they already generate IDs using genId
  2. Have made the conscious decision to allow in-memory-web-api to generate their IDs
  3. Be inexperienced enough (in the case of the tutorial followers especially) that it causes unexpected issues which in turn breaks their flow as they chase down a fix

In the case of 1 this PR changes nothing and in the cases of 2 and 3 it improves the functionality and developer experience.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@digitalpardoe
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@tonivj5
Copy link

tonivj5 commented Jul 14, 2018

any news with this?

@wardbell
Copy link
Contributor

wardbell commented Nov 1, 2018

I'm sorry but I do not see that this PR addresses the concern in issue #162 nor does it change the functionality in any way. It seems to simply spread the decision logic over two functions where one sufficed before.

Please explain what I am missing.

@digitalpardoe
Copy link
Author

digitalpardoe commented Nov 1, 2018

I'm closing the PR as it hasn't been addressed for six months and I'm no longer in a position where I have availability to discuss it further.

If someone else would like to pick it up then you're more than welcome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants