Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

xmlking
Copy link

@xmlking xmlking commented Mar 22, 2018

  1. Compatible with angular 5.x and 6.x
    For Angular v5 users, Option 1
    For Angular v6 users, Option 2
    1. Option 1:
      rxjs: "5.6.0-forward-compat.1"
    2. Option 2:
      "rxjs": "6.0.0-beta.1",
      "rxjs-compat": "6.0.0-beta.1",
  2. Packaging with ng-packagr

source without generated files
build npm run build
test npm run test
publish npm publish dist --access public

  1. integration tests
    run test app npm run start

xmlking added 5 commits March 22, 2018 01:18
2. rxjs ->  ^5.6.0-forward-compat.0
3. packaging with ng-packagr
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@xmlking
Copy link
Author

xmlking commented Mar 22, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@xmlking
Copy link
Author

xmlking commented Mar 22, 2018

For prelease testing with Angular 6.0.0-rc.0
npm i @xmlking/angular-in-memory-web-api

@wardbell
Copy link
Contributor

wardbell commented Nov 1, 2018

I'm closing because I only want to support RxJS v.6 and do not intend to support backward compat library which is deprecated in Angular v7.

Moreover, this PR updates far too many files.

But thanks for you interest and I hope you continue to find value in this library.

@wardbell wardbell closed this Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants