-
Notifications
You must be signed in to change notification settings - Fork 229
refactor: remove @angular/http #223
Conversation
cc @IgorMinar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the changelog please? The rest looks good to me.
package.json
Outdated
{ | ||
"name": "angular-in-memory-web-api", | ||
"version": "0.7.0", | ||
"version": "1.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.8 please
@wardbell FYI ^ |
BREAKING CHANGE: * `in-memory-web-api` can no longer be used with `@angular/http`
Looking forward to being able to review this PR this week. FWIW, if we’re really getting rid of old I’m particularly unhappy with the dance that lead to Not saying we should hold the PR up for those reasons. Just commentary for the moment. |
@wardbell I'd prefer any major refactoring should be done separately from the removal of http because otherwise this PR will grow uncontrollably. Let's get this in and 0.8 out. sgty? |
@IgorMinar I'm with you on that. I too would have done this in two steps, the first as in this PR. I just hate that this project so twisted to accommodate a feature (old Http) it no longer supports, leaving the code in a mysterious, convoluted state that reflects poorly on the author (me). I realize that this is my ego trip. |
@wardbell we can do that as a followup step and your contributions are welcome, but in the meantime this removal is blocking a lot of other work in angular/angular so we need to get moving on this. I asked @brandonroberts to take over this PR and cut the 0.8 release with this change. |
BREAKING CHANGE:
in-memory-web-api
can no longer be used with@angular/http