Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

CaerusKaru
Copy link
Member

BREAKING CHANGE:

  • in-memory-web-api can no longer be used with @angular/http

@CaerusKaru
Copy link
Member Author

cc @IgorMinar

Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the changelog please? The rest looks good to me.

package.json Outdated
{
"name": "angular-in-memory-web-api",
"version": "0.7.0",
"version": "1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.8 please

@IgorMinar
Copy link
Contributor

@wardbell FYI ^

BREAKING CHANGE:
* `in-memory-web-api` can no longer be used with `@angular/http`
@wardbell
Copy link
Contributor

wardbell commented Dec 10, 2018

Looking forward to being able to review this PR this week.

FWIW, if we’re really getting rid of old Http, it’s kind of nutty to keep the abstraction that supported both. I mentioned this I think in our conversation. Much of the muddiness in this library is due to the now pointless support for both http libraries.

I’m particularly unhappy with the dance that lead to RequestCore and HeadersCore (see interfaces.ts). It made life difficult for developers to get at the body and headers in a type-ful way. I don't know if you cleaned this up in this PR.

Not saying we should hold the PR up for those reasons. Just commentary for the moment.

@IgorMinar
Copy link
Contributor

@wardbell I'd prefer any major refactoring should be done separately from the removal of http because otherwise this PR will grow uncontrollably. Let's get this in and 0.8 out. sgty?

@wardbell
Copy link
Contributor

wardbell commented Dec 17, 2018

@IgorMinar I'm with you on that. I too would have done this in two steps, the first as in this PR.

I just hate that this project so twisted to accommodate a feature (old Http) it no longer supports, leaving the code in a mysterious, convoluted state that reflects poorly on the author (me). I realize that this is my ego trip.

@IgorMinar
Copy link
Contributor

@wardbell we can do that as a followup step and your contributions are welcome, but in the meantime this removal is blocking a lot of other work in angular/angular so we need to get moving on this.

I asked @brandonroberts to take over this PR and cut the 0.8 release with this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants