Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Conversation

wheelerlaw
Copy link
Contributor

When you add a new item using a post, it creates a new item in the collection using a number as the ID by default. However, when you update the item using a put, the default URL parser keeps the URL parameter as a string, which causes the ID matcher in the put method to fail.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@wheelerlaw
Copy link
Contributor Author

wheelerlaw commented Jan 16, 2017

Ok, maybe a different solution is in order since it failed the linting because of the double equals, but you get the point.

Never mind, I just used the tslint exception.

@wheelerlaw wheelerlaw force-pushed the id-matching-use-coercion branch from 9fed088 to 08d389d Compare January 16, 2017 20:46
@wardbell wardbell merged commit 6e8d047 into angular:master Jan 17, 2017
@wheelerlaw
Copy link
Contributor Author

I signed it!

wardbell added a commit that referenced this pull request May 2, 2017
wardbell added a commit that referenced this pull request May 2, 2017
wardbell added a commit that referenced this pull request May 2, 2017
wardbell added a commit that referenced this pull request May 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants